Bug 629660
| Summary: | Review Request: apache-poi - The Java API for Microsoft Documents | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Orion Poplawski <orion> |
| Component: | Package Review | Assignee: | Terje Røsten <terje.rosten> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | akurtako, fedora-package-review, musuruan, notting, tcallawa, terje.rosten |
| Target Milestone: | --- | Keywords: | Reopened |
| Target Release: | --- | Flags: | terje.rosten:
fedora-review+
|
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2010-12-21 10:21:40 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 629664 | ||
|
Description
Orion Poplawski
2010-09-02 16:01:28 UTC
Package looks clean, however the beta2 release is gone, could you update to beta3 and I will do a full review. Some initial comments: o some of the buildrequires should also be requires? * Wed Oct 27 2010 Orion Poplawski <orion.com> - 3.7-0.3.beta3 - Update to 3.7 beta3 - Add more Requires http://www.cora.nwra.com/~orion/fedora/apache-poi.spec http://www.cora.nwra.com/~orion/fedora/apache-poi-3.7-0.3.beta3.fc14.src.rpm http://koji.fedoraproject.org/koji/taskinfo?taskID=2558622 MUST Items:
+ rpmlint output ok
apache-poi.src:12: W: macro-in-comment %{version}
apache-poi.src:12: W: macro-in-comment %{reldate}
apache-poi.src: W: invalid-url Source1: http://www.ecma-international.org/publications/files/ECMA-ST/Office Open XML 1st edition\
Part 4 (PDF).zip HTTP Error 404: Not Found
apache-poi-javadoc.noarch: W: spelling-error Summary(en_US) Javadocs -> Java docs, Java-docs, Javanese
Only harmless things here.
+ named and versioned according to the Package Naming Guidelines
+ spec file name matches base package name
+ complies with all the legal guidelines:
+ License: Apache 2.0 valid, matches actual license
? No known patent problems
+ No emulator, no firmware, no binary-only or prebuilt components
+ LICENSE packaged as %doc
+ source matches upstream:
sha1sum:
28913957f7e98a37c1e42441c828f066659bfae9 poi-src-3.7-beta3-20100924.tar.gz
28913957f7e98a37c1e42441c828f066659bfae9 poi-src-3.7-beta3-20100924.tar.gz.pkg
1b3ddfa3ad13a9138f5399bdc4c10b54dd9df9d0 Office Open XML 1st edition Part 4 (PDF).zip
1b3ddfa3ad13a9138f5399bdc4c10b54dd9df9d0 Office Open XML 1st edition Part 4 (PDF).zip.pkg
+ builds on at least one arch (f15 Koji scratch build)
+ no known non-working arches, so no ExcludeArch needed
+ no missing BuildRequires (builds in mock)
+ no translations, so translation/locale guidelines don't apply
+ no shared libraries, so no ldconfig calls neeed
+ no duplicated system libraries
+ package not relocatable
! directory ownership correct
- apache-poi-manual seems strange? No useful files included?
+ no duplicate files in %files
+ permissions correct, defattr used correctly
+ macros used where possible
+ no non-code content
+ no large documentation files, so no -doc package needed
+ no %doc files required at runtime
+ no devel symlinks which would need to be in a -devel subpackage
+ all filenames are valid UTF-8
+ other packaging guidelines:
+ complies with the FHS
+ proper changelog, tags, BuildRoot, BuildRequires, Summary, Description
! no macros in Summary and Description
+ no non-UTF-8 characters
+ all relevant documentation included as %doc
+ no conflicts
SHOULD Items:
+ license already included upstream
+ no translations for description and summary provided by upstream
+ scriptlets are sane
+ no file dependencies
Java
+ jar naming ok
+ directory structure ok
+ buildrequires and requires
+ no pre-built JAR files ok
+ ant ok
Summary:
o could you comment on the patent situation, this being MS relates stuff.
o manual package seems strange as is
o macros used in descriptions, please avoid that.
Unsure:
I see the package don't include pom files, should they be included?
- We have lots of packages (e.g. OpenOffice) that can read and create Microsoft file formats. I don't think there are any patent issues here. - Descriptions are straight from http://fedoraproject.org/wiki/Packaging/Java#ant_2 I see nothing wrong with having %{name} in the descriptions. - Fixed manual package http://www.cora.nwra.com/~orion/fedora/apache-poi.spec http://www.cora.nwra.com/~orion/fedora/apache-poi-3.7-0.4.beta3.fc14.src.rpm Thanks! I need to run this past Red Hat Legal. Blocking FE-Legal. There are no legal concerns with apache-poi at this time. Lifting FE-Legal. Thanks Tom!
I think some kind information is generated without expanding macros. Such will be wrong
when using %{name} in %description section. I can't find the reference. Well, well,
do as you wish.
My last concern is about POM files. Any input here? I have package
which is built by maven and depend om poi, I then had to add a custom depmap for poi.
Any way, I leave that to you.
The package apache-poi is APPROVED.
I'm happy to add a pom if you can point me to a good one for poi. Thanks! New Package SCM Request ======================= Package Name: apache-poi Short Description: The Java API for Microsoft Documents Owners: orion Branches: f14 f13 el6 el5 InitialCC: This one might help: http://repo2.maven.org/maven2/org/apache/poi/poi/3.7-beta3/poi-3.7-beta3.pom http://www.cora.nwra.com/~orion/fedora/apache-poi.spec http://www.cora.nwra.com/~orion/fedora/apache-poi-3.7-0.5.beta3.fc14.src.rpm * Mon Nov 8 2010 Orion Poplawski <orion.com> - 3.7-0.5.beta3 - Add pom Can you give that a try? There are too many changes in rawhide for my package to build (not related to poi), however the POM and depmap looks good. Let's go for it. BTW: should jakarta-commons-logging deps be switched to apache-commons-logging? (In reply to comment #11) > There are too many changes in rawhide for my package to build (not related to > poi), however the POM and depmap looks good. Let's go for it. Great. Just waiting for the package to be created then. > BTW: should jakarta-commons-logging deps be switched to apache-commons-logging? Yup, done. Git done. Would be nice to get this closed. Orion, please import. Sorry, just forgot to close the bug. Imported and built. git seems fine, however I can't find any useful builds in koji? Oh, right, I'm waiting for the build system to be able to handle files with spaces in it. According to https://fedorahosted.org/fedora-packager/ticket/85, this should be soon. URL encoded source works. Build done: http://koji.fedoraproject.org/koji/buildinfo?buildID=210900 |