Spec URL: http://www.cora.nwra.com/~orion/fedora/jtnef.spec SRPM URL: http://www.cora.nwra.com/~orion/fedora/jtnef-1.6.0-1.fc13.src.rpm Description: The Java TNEF package is an open source code implementation of a TNEF message handler, which can be used as a command-line utility or integrated into Java- based mail applications to extract the original message content. Transport-Neutral Encapsulation Format (TNEF) is Microsoft's non-standard format for encapsulating mail which has any non-plain-text content or properties (such as rich text, embedded OLE objects, voting buttons, and sometimes just attachments). Whether or not a given message is encoded using TNEF is determined by the Outlook default settings, per-recipient setting, Exchange Server settings, and message type and content. Once a TNEF message is used, the entire message, including all the original attachments and properties, is encapsulated in a single attachment of mime type "application/ms-tnef" added to the message to be sent over the Internet. This attachment is usually named "WINMAIL.DAT", and when sent to any non-MS mail client, is useless, and makes access to the original message attachments impossible.
Hi Orion, Do you mind changing classpathx-mail BR/R to javamail? javamail package contains the Sun/Oracle opensourced javamail
* Fri Sep 3 2010 Orion Poplawski <orion.com> - 1.6.0-2 - Change to javamail from classpathx-mail http://www.cora.nwra.com/~orion/fedora/jtnef-1.6.0-2.fc13.src.rpm
I'll take this one.
Package Review ============== Key: - = N/A x = Check ! = Problem ? = Not evaluated === REQUIRED ITEMS === [x] Rpmlint output: jtnef.noarch: W: spelling-error %description -l en_US tnef -> tuneful, TEFL, tine jtnef-javadoc.noarch: W: spelling-error Summary(en_US) Javadocs -> Java docs, Java-docs, Javanese Not a problem. [x] Package is named according to the Package Naming Guidelines[1]. [x] Spec file name must match the base package name, in the format %{name}.spec. [!] Package meets the Packaging Guidelines[2]. Remove the versioned jar file and javadoc folder. [x] Package successfully compiles and builds into binary rpms. [!] Buildroot definition is not present We don't need buildroot nowadays (it's even ignored). [x] Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines[3,4]. [x] License field in the package spec file matches the actual license. License type:GPLv2+ [x] If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x] All independent sub-packages have license of their own [x] Spec file is legible and written in American English. [x] Sources used to build the package matches the upstream source, as provided in the spec URL. MD5SUM this package :790cf94af9d5ab859fddee09f4cd884c MD5SUM upstream package:790cf94af9d5ab859fddee09f4cd884c [x] All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines[5]. [x] Package must own all directories that it creates. [x] Package requires other packages for directories it uses. [x] Package does not contain duplicates in %files. [x] Permissions on files are set properly. [!] Package does NOT have a %clean section which contains rm -rf %{buildroot} (or $RPM_BUILD_ROOT). (not needed anymore) [x] Package consistently uses macros (no %{buildroot} and $RPM_BUILD_ROOT mixing) [x] Package contains code, or permissable content. [-] Fully versioned dependency in subpackages, if present. [-] Package contains a properly installed %{name}.desktop file if it is a GUI application. [x] Package does not own files or directories owned by other packages. [x] Javadoc documentation files are generated and included in -javadoc subpackage [!] Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlinks) [x] Packages have proper BuildRequires/Requires on jpackage-utils [x] Javadoc subpackages have Require: jpackage-utils [-] Package uses %global not %define [-] If package uses tarball from VCS include comment how to re-create that tarball (svn export URL, git clone URL, ...) [-] If source tarball includes bundled jar/class files these need to be removed prior to building [x] All filenames in rpm packages must be valid UTF-8. [x] Jar files are installed to %{_javadir}/%{name}.jar (see [6] for details) [-] If package contains pom.xml files install it (including depmaps) even when building with ant [-] pom files has correct add_to_maven_depmap call which resolves to the pom file (use "JPP." and "JPP-" correctly) === Other suggestions === [x] If possible use upstream build method (maven/ant/javac) [x] Avoid having BuildRequires on exact NVR unless necessary [x] Package has BuildArch: noarch (if possible) [x] Latest version is packaged. [x] Reviewer should test that the package builds in mock. === Issues === 1. Remove versioned jar and javadoc. 2. Remove BuildRoot. 3. Remove clean section. Overall the package is quite good.
* Mon Dec 6 2010 Orion Poplawski <orion.com> - 1.6.0-3 - Drop versioned jar and javadoc - Remove BuildRoot and %%clean http://www.cora.nwra.com/~orion/fedora/jtnef-1.6.0-2.fc13.src.rpm http://www.cora.nwra.com/~orion/fedora/jtnef.spec
Thanks. This package is APPROVED.
Thanks! New Package SCM Request ======================= Package Name: jtnef Short Description: Java TNEF package Owners: orion Branches: f14 f13 el6 InitialCC:
Git done (by process-git-requests).