Bug 631586
| Summary: | renegotiate transitional patch creates an unclosed comment | ||
|---|---|---|---|
| Product: | Red Hat Enterprise Linux 6 | Reporter: | Elio Maldonado Batiz <emaldona> |
| Component: | nss | Assignee: | Elio Maldonado Batiz <emaldona> |
| Status: | CLOSED ERRATA | QA Contact: | Aleš Mareček <amarecek> |
| Severity: | high | Docs Contact: | |
| Priority: | high | ||
| Version: | 6.1 | CC: | amarecek, ddumas, ebenes, jrieden, kengert, rrelyea, syeghiay |
| Target Milestone: | rc | ||
| Target Release: | 6.1 | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | nss-3.12.8-1.el6 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2011-05-19 14:03:33 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
An advisory has been issued which should help the problem described in this bug report. This report is therefore being closed with a resolution of ERRATA. For more information on therefore solution and/or where to find the updated files, please follow the link below. You may reopen this bug report if the solution does not work for you. http://rhn.redhat.com/errata/RHBA-2011-0692.html |
Description of problem: Unclosed comment in renegoitate-tansitional.patch The patch is it is Index: ./mozilla/security/nss/lib/ssl/sslsock.c =================================================================== RCS file: /cvsroot/mozilla/security/nss/lib/ssl/sslsock.c,v retrieving revision 1.66 diff -u -p -r1.66 sslsock.c --- ./mozilla/security/nss/lib/ssl/sslsock.c 26 Feb 2010 20:44:54 -0000 1.66 +++ ./mozilla/security/nss/lib/ssl/sslsock.c 1 Mar 2010 18:05:10 -0000 @@ -181,7 +181,7 @@ static sslOptions ssl_defaults = { PR_FALSE, /* noLocks */ PR_FALSE, /* enableSessionTickets */ PR_FALSE, /* enableDeflate */ - 2, /* enableRenegotiation (default: requires extension) */ + 3, /* enableRenegotiation (default: transitional) PR_FALSE, /* requireSafeNegotiation */ }; which upon applications gives .... PR_FALSE, /* enableDeflate */ 3, /* enableRenegotiation (default: transitional) PR_FALSE, /* requireSafeNegotiation */ }; ..... The last value is lost. This patch was as intended when it was first created and the comment spanned two lines. Since then the code changed and the comment became a one line comment. The patch tool never compalined nor did the compiler. It compiles but is not the intended code. Version-Release number of selected component (if applicable): nss-3.12.7-2.el6 How reproducible: Always Steps to Reproduce: 1. Apply the patch 2. Examine the resultant patched file 3. The comment goes into the next line Actual results: ... 3, /* enableRenegotiation (default: transitional) PR_FALSE, /* requireSafeNegotiation */ }; Expected results: ... 3, /* enableRenegotiation (default: transitional) */ PR_FALSE, /* requireSafeNegotiation */ }; Additional info: