Note: This bug is displayed in read-only format because
the product is no longer active in Red Hat Bugzilla.
RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
DescriptionElio Maldonado Batiz
2010-09-07 23:29:47 UTC
Description of problem: Unclosed comment in renegoitate-tansitional.patch
The patch is it is
Index: ./mozilla/security/nss/lib/ssl/sslsock.c
===================================================================
RCS file: /cvsroot/mozilla/security/nss/lib/ssl/sslsock.c,v
retrieving revision 1.66
diff -u -p -r1.66 sslsock.c
--- ./mozilla/security/nss/lib/ssl/sslsock.c 26 Feb 2010 20:44:54 -0000 1.66
+++ ./mozilla/security/nss/lib/ssl/sslsock.c 1 Mar 2010 18:05:10 -0000
@@ -181,7 +181,7 @@ static sslOptions ssl_defaults = {
PR_FALSE, /* noLocks */
PR_FALSE, /* enableSessionTickets */
PR_FALSE, /* enableDeflate */
- 2, /* enableRenegotiation (default: requires extension) */
+ 3, /* enableRenegotiation (default: transitional)
PR_FALSE, /* requireSafeNegotiation */
};
which upon applications gives
....
PR_FALSE, /* enableDeflate */
3, /* enableRenegotiation (default: transitional)
PR_FALSE, /* requireSafeNegotiation */
};
.....
The last value is lost.
This patch was as intended when it was first created and the comment spanned two lines. Since then the code changed and the comment became a one line comment. The patch tool never compalined nor did the compiler. It compiles but is not the intended code.
Version-Release number of selected component (if applicable):
nss-3.12.7-2.el6
How reproducible: Always
Steps to Reproduce:
1. Apply the patch
2. Examine the resultant patched file
3. The comment goes into the next line
Actual results:
...
3, /* enableRenegotiation (default: transitional)
PR_FALSE, /* requireSafeNegotiation */
};
Expected results:
...
3, /* enableRenegotiation (default: transitional) */
PR_FALSE, /* requireSafeNegotiation */
};
Additional info:
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.
http://rhn.redhat.com/errata/RHBA-2011-0692.html
Description of problem: Unclosed comment in renegoitate-tansitional.patch The patch is it is Index: ./mozilla/security/nss/lib/ssl/sslsock.c =================================================================== RCS file: /cvsroot/mozilla/security/nss/lib/ssl/sslsock.c,v retrieving revision 1.66 diff -u -p -r1.66 sslsock.c --- ./mozilla/security/nss/lib/ssl/sslsock.c 26 Feb 2010 20:44:54 -0000 1.66 +++ ./mozilla/security/nss/lib/ssl/sslsock.c 1 Mar 2010 18:05:10 -0000 @@ -181,7 +181,7 @@ static sslOptions ssl_defaults = { PR_FALSE, /* noLocks */ PR_FALSE, /* enableSessionTickets */ PR_FALSE, /* enableDeflate */ - 2, /* enableRenegotiation (default: requires extension) */ + 3, /* enableRenegotiation (default: transitional) PR_FALSE, /* requireSafeNegotiation */ }; which upon applications gives .... PR_FALSE, /* enableDeflate */ 3, /* enableRenegotiation (default: transitional) PR_FALSE, /* requireSafeNegotiation */ }; ..... The last value is lost. This patch was as intended when it was first created and the comment spanned two lines. Since then the code changed and the comment became a one line comment. The patch tool never compalined nor did the compiler. It compiles but is not the intended code. Version-Release number of selected component (if applicable): nss-3.12.7-2.el6 How reproducible: Always Steps to Reproduce: 1. Apply the patch 2. Examine the resultant patched file 3. The comment goes into the next line Actual results: ... 3, /* enableRenegotiation (default: transitional) PR_FALSE, /* requireSafeNegotiation */ }; Expected results: ... 3, /* enableRenegotiation (default: transitional) */ PR_FALSE, /* requireSafeNegotiation */ }; Additional info: