Bug 632056 (libsocialweb-qt)

Summary: Review Request: libsocialweb-qt - Qt4 API for libsocialweb client DBUS interface
Product: [Fedora] Fedora Reporter: Chen Lei <supercyper1>
Component: Package ReviewAssignee: Nobody's working on this, feel free to take it <nobody>
Status: CLOSED NOTABUG QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: low    
Version: rawhideCC: fedora-package-review, notting, rdieter
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2011-08-19 00:22:48 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Chen Lei 2010-09-09 03:55:18 UTC
Description:

libsocialweb-qt is a library that provides a Qt4 API for interacting with
libsocialweb via DBUS.

Links:

http://dl.dropbox.com/u/1338197/1/libsocialweb-qt-0.1.2-1.fc13.src.rpm
http://dl.dropbox.com/u/1338197/1/libsocialweb-qt.spec

Comment 1 Jason Tibbitts 2010-11-25 01:58:07 UTC
This might be of interest to the KDE folks.

Comment 2 Rex Dieter 2011-05-20 15:09:47 UTC
I can take a stab at it.

Comment 3 Rex Dieter 2011-05-20 15:18:50 UTC
Looks like rest >= 0.7 is required, I'm seeing the following trying to build this on my f14 box against rest-0.6.4-2.fc14.1.x86_64

Package rest-0.7 was not found in the pkg-config search path.
Perhaps you should add the directory containing `rest-0.7.pc'
to the PKG_CONFIG_PATH environment variable
No package 'rest-0.7' found
Package rest-0.7 was not found in the pkg-config search path.
Perhaps you should add the directory containing `rest-0.7.pc'
to the PKG_CONFIG_PATH environment variable
No package 'rest-0.7' found
Package rest-0.7 was not found in the pkg-config search path.
Perhaps you should add the directory containing `rest-0.7.pc'
to the PKG_CONFIG_PATH environment variable
No package 'rest-0.7' found
Package rest-extras-0.7 was not found in the pkg-config search path.
Perhaps you should add the directory containing `rest-extras-0.7.pc'
to the PKG_CONFIG_PATH environment variable
No package 'rest-extras-0.7' found
Package rest-extras-0.7 was not found in the pkg-config search path.
Perhaps you should add the directory containing `rest-extras-0.7.pc'
to the PKG_CONFIG_PATH environment variable
No package 'rest-extras-0.7' found
Package rest-extras-0.7 was not found in the pkg-config search path.
Perhaps you should add the directory containing `rest-extras-0.7.pc'
to the PKG_CONFIG_PATH environment variable
No package 'rest-extras-0.7' found

Comment 4 Rex Dieter 2011-05-20 15:31:09 UTC
$ rpmlint *.rpm x86_64/*.rpm
libsocialweb-qt.src: W: invalid-url Source0: libsocialweb-qt-0.1.2.tar.bz2
libsocialweb-qt.x86_64: E: incorrect-fsf-address /usr/share/doc/libsocialweb-qt-0.1.2/COPYING
libsocialweb-qt-debuginfo.x86_64: W: hidden-file-or-dir /usr/src/debug/libsocialweb-qt-0.1.2/.moc
libsocialweb-qt-debuginfo.x86_64: W: hidden-file-or-dir /usr/src/debug/libsocialweb-qt-0.1.2/.moc
libsocialweb-qt-devel.x86_64: W: no-documentation
4 packages and 0 specfiles checked; 1 errors, 4 warnings.

mostly harmless

Naming: ok

License: ok

Sources: meh, though hard to verify as-is. :-/

Builds/installs: ok, though

1.  SHOULD: use versioned BuildRequires: rest-devel >= 0.7

2.  SHOULD: move
sed -i 's|LIBDIR = .*$|LIBDIR = %{_libdir}|' libsocialweb-qt.pro
to %prep section, instead of %build

macros: ok

scriptlets: ok


I won't consider those SHOULD items blockers, but please do address them prior to doing any official builds.


APPROVED.

Comment 5 Rex Dieter 2011-07-14 17:03:32 UTC
ping?

(I'll let this go another week or 2 before closing it out due to inactivity)

Comment 6 Rex Dieter 2011-08-19 00:22:48 UTC
:(  closing.