Bug 63291
| Summary: | xemacs's browse-url passes -x to galeon | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Retired] Red Hat Raw Hide | Reporter: | Jens Petersen <petersen> | ||||||
| Component: | xemacs | Assignee: | Trond Eivind Glomsrxd <teg> | ||||||
| Status: | CLOSED RAWHIDE | QA Contact: | Aaron Brown <abrown> | ||||||
| Severity: | medium | Docs Contact: | |||||||
| Priority: | medium | ||||||||
| Version: | 1.0 | ||||||||
| Target Milestone: | --- | ||||||||
| Target Release: | --- | ||||||||
| Hardware: | i386 | ||||||||
| OS: | Linux | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2002-05-01 21:22:27 UTC | Type: | --- | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Attachments: |
|
||||||||
Created attachment 53564 [details]
patch to browse-url.el: only pass --existing to galeon when not using new-window
To clarify, --existing should only to passed when browse-url-new-window-flag nil. The patch I attached does that. Created attachment 53565 [details]
the right patch
Sounds like a good thing to go in upstream :) Yep. Simon Josefsson told me he already committed a fix into xemacs-package cvs. It's very annoying though, so I wouldn't mind putting a placeholder patch into our xemacs until it appears in our sumo. If you don't object, you can assign this bug to me. :) Packages have been updated, and the sumo packages from 2002-07-20 are included in xemacs-21.4.8-10 Confirmed fixed. |
Description of Problem: -x (--existing) shouldn't be passed to galeon since it overrides --new-tab. How Reproducible: every time Steps to Reproduce: 0. start browsing in galeon with tabs enabled 1. start a vanilla xemacs 2. eval (setq browse-url-browser-function 'browse-url-galeon browse-url-galeon-new-window-is-tab t browse-url-new-window-flag t) 3. enter http://www.redhat.com, leaving point at end of url 4. M-x browse-url RET RET Actual Results: The page given comes up in the current tab. Expected Results: The page should come up in a new tab. Additional Information: The attached patch fixes the problem.