Bug 63291 - xemacs's browse-url passes -x to galeon
xemacs's browse-url passes -x to galeon
Status: CLOSED RAWHIDE
Product: Red Hat Raw Hide
Classification: Retired
Component: xemacs (Show other bugs)
1.0
i386 Linux
medium Severity medium
: ---
: ---
Assigned To: Trond Eivind Glomsrxd
Aaron Brown
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2002-04-11 23:40 EDT by Jens Petersen
Modified: 2007-04-18 12:41 EDT (History)
0 users

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2002-05-01 17:22:27 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:


Attachments (Terms of Use)
patch to browse-url.el: only pass --existing to galeon when not using new-window (651 bytes, patch)
2002-04-11 23:51 EDT, Jens Petersen
no flags Details | Diff
the right patch (587 bytes, patch)
2002-04-12 00:28 EDT, Jens Petersen
no flags Details | Diff

  None (edit)
Description Jens Petersen 2002-04-11 23:40:37 EDT
Description of Problem:
-x (--existing) shouldn't be passed to galeon since it overrides
--new-tab.

How Reproducible:
every time

Steps to Reproduce:
0. start browsing in galeon with tabs enabled
1. start a vanilla xemacs
2. eval
(setq browse-url-browser-function 'browse-url-galeon
      browse-url-galeon-new-window-is-tab t
      browse-url-new-window-flag t)
3. enter http://www.redhat.com, leaving point at end of url
4. M-x browse-url RET RET

Actual Results:
The page given comes up in the current tab.

Expected Results:
The page should come up in a new tab.

Additional Information:
The attached patch fixes the problem.
Comment 1 Jens Petersen 2002-04-11 23:51:33 EDT
Created attachment 53564 [details]
patch to browse-url.el: only pass --existing to galeon when not using new-window
Comment 2 Jens Petersen 2002-04-11 23:54:13 EDT
To clarify, --existing should only to passed when
browse-url-new-window-flag nil.  The patch I attached does that.
Comment 3 Jens Petersen 2002-04-12 00:28:24 EDT
Created attachment 53565 [details]
the right patch
Comment 4 Trond Eivind Glomsrxd 2002-04-12 11:02:30 EDT
Sounds like a good thing to go in upstream :)
Comment 5 Jens Petersen 2002-04-15 03:08:45 EDT
Yep.  Simon Josefsson told me he already committed a fix into
xemacs-package cvs.  It's very annoying though, so I wouldn't mind
putting a placeholder patch into our xemacs until it appears in our
sumo.  If you don't object, you can assign this bug to me. :)
Comment 6 Trond Eivind Glomsrxd 2002-07-25 19:39:30 EDT
Packages have been updated, and the sumo packages from 2002-07-20 are included
in xemacs-21.4.8-10
Comment 7 Jens Petersen 2002-07-31 03:12:17 EDT
Confirmed fixed.

Note You need to log in before you can comment on or make changes to this bug.