Bug 633549
| Summary: | Review Request: rubygem-linode - Ruby wrapper for the Linode API | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Michael Stahnke <mastahnke> |
| Component: | Package Review | Assignee: | Mamoru TASAKA <mtasaka> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, notting |
| Target Milestone: | --- | Flags: | mtasaka:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | rubygem-linode-0.6.2-1.fc13 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2010-10-03 17:41:36 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Michael Stahnke
2010-09-13 22:25:40 UTC
I will take this package. Instead I will appreciate it if you would review my review request (bug 634759) For 0.6.2-1:
* Dependency
- Writing ">= 0.4.4" on "(Build)Requires: rubygem(httparty)" is not needed
https://fedoraproject.org/wiki/Packaging/Guidelines#Explicit_Requires
- If you use "BuildRequires(check)" syntax, I guess
"rubygem(mocha)" "rubygem(httparty)" are needed only for %check so
using "BR(check)" is apppropriate
! Note that rubygem(httparty) is also needed for Requires, as you already
wrote so.
* %{geminstdir}/linode.gemspec
- Would you check if this is really needed?
* %doc attribute in -doc subpackage
- I think writing %doc attribute in -doc subpackage is redundant because
the name of the rpm already indicates that the rpm is for documentation.
Well,
- So would you check if %{geminstdir}/linode.gemspec is needed?
(i.e. I think this file is not needed). Note that gemspec file
is also installed under %gemdir/specifications/
* BR(check): rubygem(httparty) is written twice.
Sorry, I thought I had fixed those issues. I was working on two different systems and uploaded the incorrect one. Fixed, and bumped. http://stahnma.fedorapeople.org/reviews/rubygem-linode-0.6.2-3.fc15.src.rpm According to http://code.google.com/p/ruby-ole/ it is GPLv2. Should I file a bug with upstream to include that in the file package? (In reply to comment #6) > According to http://code.google.com/p/ruby-ole/ it is GPLv2. Should I file a > bug with upstream to include that in the file package? (note that this comment is for bug 634608 (rubygem-ruby-ole) ) Okay. --------------------------------------------------------------- This package (rubygem-linode) is APPROVED by mtasaka --------------------------------------------------------------- New Package SCM Request ======================= Package Name: rubygem-linnode Short Description: Ruby wrapper for the linode API Owners: stahnma Branches: F13 F14 EL5 EL6 InitialCC: (In reply to comment #8) > New Package SCM Request > ======================= > Package Name: rubygem-linnode > Short Description: Ruby wrapper for the linode API > Owners: stahnma > Branches: F13 F14 EL5 EL6 > InitialCC: Would you recheck "Package Name"? New Package SCM Request ======================= Package Name: rubygem-linode Short Description: Ruby wrapper for the linode API Owners: stahnma Branches: F13 F14 EL5 EL6 InitialCC: Git done (by process-git-requests). rubygem-linode-0.6.2-1.fc13 has been submitted as an update for Fedora 13. https://admin.fedoraproject.org/updates/rubygem-linode-0.6.2-1.fc13 rubygem-linode-0.6.2-1.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/rubygem-linode-0.6.2-1.fc14 rubygem-linode-0.6.2-1.fc14 has been pushed to the Fedora 14 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update rubygem-linode'. You can provide feedback for this update here: https://admin.fedoraproject.org/updates/rubygem-linode-0.6.2-1.fc14 Closing. rubygem-linode-0.6.2-1.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report. rubygem-linode-0.6.2-1.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report. |