Bug 634759 - Review Request: rubygem-pkg-config - A pkg-config implmenetation by Ruby
Summary: Review Request: rubygem-pkg-config - A pkg-config implmenetation by Ruby
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Michael Stahnke
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 635302
TreeView+ depends on / blocked
 
Reported: 2010-09-16 22:12 UTC by Mamoru TASAKA
Modified: 2010-12-28 00:49 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2010-09-25 21:38:47 UTC
Type: ---
Embargoed:
mastahnke: fedora-review+
j: fedora-cvs+


Attachments (Terms of Use)

Description Mamoru TASAKA 2010-09-16 22:12:57 UTC
Spec URL: http://mtasaka.fedorapeople.org/Review_request/rubygem-pkg-config/rubygem-pkg-config.spec
SRPM URL: http://mtasaka.fedorapeople.org/Review_request/rubygem-pkg-config/rubygem-pkg-config-1.0.3-1.fc.src.rpm
Description: 
This gem contains a pkg-config implementation by Ruby

Scratch build log:
For F-14:
http://mtasaka.fedorapeople.org/Review_request/rubygem-pkg-config/MOCK-rubygem-pkg-config.log

! Currently koji scratch build is not available. Rebuilding this
  needs rubygem-hoe >= 2.6.2-3 (not 2.6.1-3), which will be pushed
  into testing repositories with next push

Comment 1 Michael Stahnke 2010-09-17 02:35:59 UTC
I'll take this one.  I'll check it out in depth once rubygem-hoe is in fc14 testing.  (tomorrow I would guess)

Comment 2 Michael Stahnke 2010-09-17 14:47:50 UTC
Should this build in rawhide?  

It looks like perhaps hoe was not updated in rawhide?  I am pulling in rubygem-hoe.noarch 0:2.6.2-2.fc14 from mock.  




This is a snip of build.log from mock, fedora-rawhide-i386


Executing(%check): /bin/sh -e /var/tmp/rpm-tmp.yQiJNx
+ umask 022
+ cd /builddir/build/BUILD
+ cd rubygem-pkg-config-1.0.3
+ unset DISPLAY
+ pushd ./usr/lib/ruby/gems/1.8/gems/pkg-config-1.0.3
~/build/BUILD/rubygem-pkg-config-1.0.3/usr/lib/ruby/gems/1.8/gems/pkg-config-1.0.3 ~/build/BUILD/rubygem-pkg-config-1.0.3
+ rake test --verbose --trace
(in /builddir/build/BUILD/rubygem-pkg-config-1.0.3/usr/lib/ruby/gems/1.8/gems/pkg-config-1.0.3)
rake aborted!
No such file or directory - Manifest.txt
/usr/lib/ruby/gems/1.8/gems/hoe-2.6.2/lib/hoe.rb:626:in `initialize'
/usr/lib/ruby/gems/1.8/gems/hoe-2.6.2/lib/hoe.rb:626:in `open'
/usr/lib/ruby/gems/1.8/gems/hoe-2.6.2/lib/hoe.rb:626:in `read_utf'
/usr/lib/ruby/gems/1.8/gems/hoe-2.6.2/lib/hoe.rb:355:in `define_spec'
/usr/lib/ruby/site_ruby/1.8/rubygems/specification.rb:425:in `initialize'

Comment 3 Mamoru TASAKA 2010-09-17 15:02:01 UTC
(In reply to comment #2)
> Should this build in rawhide?  
> 
> It looks like perhaps hoe was not updated in rawhide?  I am pulling in
> rubygem-hoe.noarch 0:2.6.2-2.fc14 from mock.

- Yes, once rubygem-hoe-2.6.2-3.fc14 is pushed into F14 stable
  repository, it is also inherited into rawhide tree.
  And I won't build packages for F-15 for now unless it is really
  needed.

> This is a snip of build.log from mock, fedora-rawhide-i386
> 
> 
> Executing(%check): /bin/sh -e /var/tmp/rpm-tmp.yQiJNx
> + umask 022
> + cd /builddir/build/BUILD
> + cd rubygem-pkg-config-1.0.3
> + unset DISPLAY
> + pushd ./usr/lib/ruby/gems/1.8/gems/pkg-config-1.0.3
> ~/build/BUILD/rubygem-pkg-config-1.0.3/usr/lib/ruby/gems/1.8/gems/pkg-config-1.0.3
> ~/build/BUILD/rubygem-pkg-config-1.0.3
> + rake test --verbose --trace
> (in
> /builddir/build/BUILD/rubygem-pkg-config-1.0.3/usr/lib/ruby/gems/1.8/gems/pkg-config-1.0.3)
> rake aborted!
> No such file or directory - Manifest.txt
> /usr/lib/ruby/gems/1.8/gems/hoe-2.6.2/lib/hoe.rb:626:in `initialize'
> /usr/lib/ruby/gems/1.8/gems/hoe-2.6.2/lib/hoe.rb:626:in `open'
> /usr/lib/ruby/gems/1.8/gems/hoe-2.6.2/lib/hoe.rb:626:in `read_utf'
> /usr/lib/ruby/gems/1.8/gems/hoe-2.6.2/lib/hoe.rb:355:in `define_spec'
> /usr/lib/ruby/site_ruby/1.8/rubygems/specification.rb:425:in `initialize'

- Yes, so rubygem-hoe >= 2.6.2-3 is needed (this issue is reported
  on hoe bug tracker)

Comment 4 Michael Stahnke 2010-09-17 20:32:30 UTC
> 
> - Yes, once rubygem-hoe-2.6.2-3.fc14 is pushed into F14 stable
>   repository, it is also inherited into rawhide tree.
>   And I won't build packages for F-15 for now unless it is really
>   needed.
> 

FESCo officially recommended publishing separate rawhide builds a few weeks ago. I would also like to see a rawhide build. 
  

rubygem-pkg-config.src: W: spelling-error Summary(en_US) implmenetation -> implementation

I assume you can fix that upon import. Everything else looks good.  

---------------------------------------------
Package rubygem-pkg-config is APPROVED.
---------------------------------------------

Comment 5 Mamoru TASAKA 2010-09-17 21:10:30 UTC
Thank you for review!

New Package SCM Request
=======================
Package Name:        rubygem-pkg-config
Short Description:   A pkg-config implmenetation by Ruby
Owners:              mtasaka
Branches:            f14 f13 f12
InitialCC:

Comment 6 Kevin Fenzi 2010-09-19 19:27:47 UTC
Git done (by process-git-requests).

Comment 7 Mamoru TASAKA 2010-09-25 21:38:47 UTC
Rebuilt for F-14/13/12, submitted push requests on bodhi.
Thank you for the review and GIT procedure, closing.

Comment 8 Michael Stahnke 2010-12-25 21:38:19 UTC
Mamoru, can I maintain this in EPEL?

Comment 9 Mamoru TASAKA 2010-12-27 05:08:54 UTC
(In reply to comment #8)
> Mamoru, can I maintain this in EPEL?

Please feel free to do so.

Comment 10 Michael Stahnke 2010-12-27 16:17:17 UTC
Package Change Request
======================
Package Name: rubygem-pkg-config
New Branches: el5 el6
Owners: stahnma
InitialCC: 
Mamoru has stated I may maintain any of his ruby packages in EPEL

Comment 11 Jason Tibbitts 2010-12-28 00:49:20 UTC
Git done (by process-git-requests).


Note You need to log in before you can comment on or make changes to this bug.