Bug 637489 (perl-KinoSearch1)
| Summary: | Review Request: perl-KinoSearch1 - Search engine library | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Iain Arnell <iarnell> |
| Component: | Package Review | Assignee: | Marcela Mašláňová <mmaslano> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | low | ||
| Version: | rawhide | CC: | fedora-package-review, notting |
| Target Milestone: | --- | Flags: | mmaslano:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | http://search.cpan.org/dist/KinoSearch1/ | ||
| Whiteboard: | |||
| Fixed In Version: | perl-KinoSearch1-1.00-2.fc13 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2010-10-12 12:46:35 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 639557 | ||
|
Description
Iain Arnell
2010-09-26 06:50:20 UTC
Rpmlint: only pre F-12 warnings License: ApacheLicense2.0.txt is mentioned in %doc, but license is set to GPL+ or Artistic. That's strange. Please verify correct license. Macros: we'd like to have vendor path only for 3rd party RPMs in future. Could you think about moving them into core? BR: I suggest adding perl(Time::HiRes) as BR, because it's sub-package in perl core. No review blockers -> ACCEPT It looks like Ian Burrell had similar concerns about the license for KinoSearch (from which KinoSearch1 has been forked). The perl KinoSearch distribution is all original code under "the same terms as perl itself", but is loosely based on Lucene (which is ASL 2.0). I'll copy the relevant clarification from perl-KinoSearch spec. As for vendor/core, I think that could use some discussion on the mailing list. I know it's just a matter of labelling at the minute, but if we do need to split core and vendor again for some reason, it will be a lot easier if we still have the vendor macros in the specs. New Package CVS Request ======================= Package Name: perl-KinoSearch1 Short Description: Search engine library Owners: iarnell Branches: f13 f14 InitialCC: perl-sig Git done (by process-git-requests). perl-KinoSearch1-1.00-2.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/perl-KinoSearch1-1.00-2.fc14 perl-KinoSearch1-1.00-2.fc13 has been submitted as an update for Fedora 13. https://admin.fedoraproject.org/updates/perl-KinoSearch1-1.00-2.fc13 perl-KinoSearch1-1.00-2.fc14 has been pushed to the Fedora 14 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update perl-KinoSearch1'. You can provide feedback for this update here: https://admin.fedoraproject.org/updates/perl-KinoSearch1-1.00-2.fc14 perl-KinoSearch1-1.00-2.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report. perl-KinoSearch1-1.00-2.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report. |