Bug 637489 (perl-KinoSearch1) - Review Request: perl-KinoSearch1 - Search engine library
Summary: Review Request: perl-KinoSearch1 - Search engine library
Keywords:
Status: CLOSED ERRATA
Alias: perl-KinoSearch1
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
low
medium
Target Milestone: ---
Assignee: Marcela Mašláňová
QA Contact: Fedora Extras Quality Assurance
URL: http://search.cpan.org/dist/KinoSearch1/
Whiteboard:
Depends On:
Blocks: 639557
TreeView+ depends on / blocked
 
Reported: 2010-09-26 06:50 UTC by Iain Arnell
Modified: 2010-10-14 06:35 UTC (History)
2 users (show)

Fixed In Version: perl-KinoSearch1-1.00-2.fc13
Clone Of:
Environment:
Last Closed: 2010-10-12 12:46:35 UTC
Type: ---
Embargoed:
mmaslano: fedora-review+
kevin: fedora-cvs+


Attachments (Terms of Use)

Description Iain Arnell 2010-09-26 06:50:20 UTC
Spec URL: http://fedorapeople.org/~iarnell/review/perl-KinoSearch1.spec
SRPM URL: http://fedorapeople.org/~iarnell/review/perl-KinoSearch1-1.00-1.fc13.src.rpm

Description:
KinoSearch1 is a loose port of the Java search engine library Apache
Lucene, written in Perl and C. The archetypal application is website
search, but it can be put to many different uses.

Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=2489682

*rt-0.10_01

Comment 1 Marcela Mašláňová 2010-10-04 08:34:50 UTC
Rpmlint: only pre F-12 warnings
License: ApacheLicense2.0.txt is mentioned in %doc, but license is set to GPL+ or Artistic. That's strange. Please verify correct license.
Macros: we'd like to have vendor path only for 3rd party RPMs in future. Could you think about moving them into core?
BR: I suggest adding perl(Time::HiRes) as BR, because it's sub-package in perl core.

No review blockers -> ACCEPT

Comment 2 Iain Arnell 2010-10-04 15:37:39 UTC
It looks like Ian Burrell had similar concerns about the license for KinoSearch (from which KinoSearch1 has been forked). The perl KinoSearch distribution is all original code under "the same terms as perl itself", but is loosely based on Lucene (which is ASL 2.0). I'll copy the relevant clarification from perl-KinoSearch spec.

As for vendor/core, I think that could use some discussion on the mailing list. I know it's just a matter of labelling at the minute, but if we do need to split core and vendor again for some reason, it will be a lot easier if we still have the vendor macros in the specs.

Comment 3 Iain Arnell 2010-10-04 15:38:32 UTC
New Package CVS Request
=======================
Package Name: perl-KinoSearch1
Short Description: Search engine library
Owners: iarnell
Branches: f13 f14
InitialCC: perl-sig

Comment 4 Kevin Fenzi 2010-10-04 19:08:15 UTC
Git done (by process-git-requests).

Comment 5 Fedora Update System 2010-10-05 03:34:27 UTC
perl-KinoSearch1-1.00-2.fc14 has been submitted as an update for Fedora 14.
https://admin.fedoraproject.org/updates/perl-KinoSearch1-1.00-2.fc14

Comment 6 Fedora Update System 2010-10-05 03:34:34 UTC
perl-KinoSearch1-1.00-2.fc13 has been submitted as an update for Fedora 13.
https://admin.fedoraproject.org/updates/perl-KinoSearch1-1.00-2.fc13

Comment 7 Fedora Update System 2010-10-05 05:19:47 UTC
perl-KinoSearch1-1.00-2.fc14 has been pushed to the Fedora 14 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update perl-KinoSearch1'.  You can provide feedback for this update here: https://admin.fedoraproject.org/updates/perl-KinoSearch1-1.00-2.fc14

Comment 8 Fedora Update System 2010-10-12 12:46:30 UTC
perl-KinoSearch1-1.00-2.fc14 has been pushed to the Fedora 14 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 9 Fedora Update System 2010-10-14 06:35:45 UTC
perl-KinoSearch1-1.00-2.fc13 has been pushed to the Fedora 13 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.