Bug 637684

Summary: python-urlgrabber grabber.py has an extraneous 'def geturl'
Product: [Fedora] Fedora Reporter: Bruce Jerrick <bmj001>
Component: python-urlgrabberAssignee: James Antill <james.antill>
Status: CLOSED UPSTREAM QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: low Docs Contact:
Priority: low    
Version: 14CC: james.antill
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2010-09-27 17:58:13 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Bruce Jerrick 2010-09-27 05:53:57 UTC
Description of problem:
/usr/lib/python*/site-packages/urlgrabber/grabber.py has two 'def geturl'
in the 'class PyCurlFileObject' definition.

Version-Release number of selected component (if applicable):
python-urlgrabber-3.9.1-7.fc13 and later, including
python-urlgrabber-3.9.1-7.fc14

How reproducible:
100%

Steps to Reproduce:
1. grep -n "def geturl" /usr/lib/python*/site-packages/urlgrabber/grabber.py

Actual results:
1066:    def geturl(self):
1645:    def geturl(self):
(yes, they are in the same class definition)

Expected results:
Only one geturl definition.

Additional info:
Sometime between 3.9.1-2.fc12 and 3.9.1-4.fc12, a 'yum include' problem was
fixed by adding a missing 'def geturl' (rhbz 529998).
My guess is that this has been fixed upstream but the patch still exists
(I don't have a source package to check that).

Comment 1 seth vidal 2010-09-27 17:58:13 UTC
odd - there are, in fact, two of them. For no good reason.

I've fixed this upstream.

thanks