Bug 637684 - python-urlgrabber grabber.py has an extraneous 'def geturl'
Summary: python-urlgrabber grabber.py has an extraneous 'def geturl'
Keywords:
Status: CLOSED UPSTREAM
Alias: None
Product: Fedora
Classification: Fedora
Component: python-urlgrabber
Version: 14
Hardware: All
OS: Linux
low
low
Target Milestone: ---
Assignee: James Antill
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2010-09-27 05:53 UTC by Bruce Jerrick
Modified: 2014-01-21 23:16 UTC (History)
1 user (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2010-09-27 17:58:13 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Bruce Jerrick 2010-09-27 05:53:57 UTC
Description of problem:
/usr/lib/python*/site-packages/urlgrabber/grabber.py has two 'def geturl'
in the 'class PyCurlFileObject' definition.

Version-Release number of selected component (if applicable):
python-urlgrabber-3.9.1-7.fc13 and later, including
python-urlgrabber-3.9.1-7.fc14

How reproducible:
100%

Steps to Reproduce:
1. grep -n "def geturl" /usr/lib/python*/site-packages/urlgrabber/grabber.py

Actual results:
1066:    def geturl(self):
1645:    def geturl(self):
(yes, they are in the same class definition)

Expected results:
Only one geturl definition.

Additional info:
Sometime between 3.9.1-2.fc12 and 3.9.1-4.fc12, a 'yum include' problem was
fixed by adding a missing 'def geturl' (rhbz 529998).
My guess is that this has been fixed upstream but the patch still exists
(I don't have a source package to check that).

Comment 1 seth vidal 2010-09-27 17:58:13 UTC
odd - there are, in fact, two of them. For no good reason.

I've fixed this upstream.

thanks


Note You need to log in before you can comment on or make changes to this bug.