Bug 638418
| Summary: | Review Request: ehcache (for cloud package in bug #630179) | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Rudd-O DragonFear <rudd-o> |
| Component: | Package Review | Assignee: | Nobody's working on this, feel free to take it <nobody> |
| Status: | CLOSED NOTABUG | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | low | ||
| Version: | rawhide | CC: | akurtako, fedora-package-review, notting |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2010-11-24 15:38:52 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 201449, 630179 | ||
|
Description
Rudd-O DragonFear
2010-09-28 23:41:16 UTC
Fixed rpmlint warnings: (the source URL cannot be fixed because the... not so clever release managers at ehcache decided not to include any build system in the sources they release. so I basically ship with the same source as the JPP project) http://download.cloud.com/foss/fedora/proposed/ehcache-1.2.0.3-4.src.rpm I can review this one and sponsor you but I have few comments: 1. If we don't have a clear way where are the sources coming from or how to generate the tarball it's a nogo. 2. Choose only one of the build systems either ant or maven. 3. Always provide a unversioned javadoc and remove these post/postun sections for javadoc. 4. Drop gcj-support - we don't need it nowadays. 5. Ehcache has seen big restructuring - http://svn.terracotta.org/svn/ehcache/tags/ and http://ehcache.org/roadmap.html# and http://oss.sonatype.org/content/repositories/sourceforge-releases/net/sf/ehcache/ehcache/ 6. Update to latest version - 2.2.0 7. Fix file attributes to the defaults for fedora. And this is only from the first sight :). Also if you drop gcj you won't need gnu-crypto. Are you still interested in getting this into Fedora or we should close the bug? There was a comment, then more than a month passed, then a ping, and now more than a week has passed and there's been no response from the submitter. That's what we consider as stale, so I'll go ahead and close out the stack of submissions. |