Bug 639272

I fixed some BuildRequire dependencies, now it builds fine in Koji:

http://koji.fedoraproject.org/koji/taskinfo?taskID=2505839

Spec URL: http://mifo.sk/RPMS/rubygem-rack-accept.spec
SRPM URL: http://koji.fedoraproject.org/koji/getfile?taskID=2505839&name=rubygem-rack-accept-0.4.3-3.fc13.src.rpm

Some notes:

* Unused macros
  - It seems that %ruby_sitelib macro is used nowhere.

* Requires/BuildRequires
  - rubygem(rake) is for $ rake test and s.add_development_dependency
    in gemspec file, so this is not needed for "Requires"
    (for BuildRequires this is needed).

  - ">= 0.4" or ">= 0" parts on (Build)Requires: rubygem(foo) are
    not needed because packages on currently supported Fedora
    branches all satisfy these version dependencies.
    https://fedoraproject.org/wiki/Packaging/Guidelines#Explicit_Requires

* Directory ownership issue
  - The directory %geminstdir itself is not owned by any packages.

* %files
  - Please check if %geminstdir/%gemname.gemspec is really needed
    ( I guess not. Note that gemspec file is also installed under
      %gemdir/specifications )

* Document files
  - I think for this package -doc file should be created and the following
    entries should be moved to -doc:
------------------------------------------------------------------
%{geminstdir}/test
%{geminstdir}/Rakefile
%{geminstdir}/doc
%{gemdir}/doc/%{gemname}-%{version}
------------------------------------------------------------------
    ( I usually think that especially test/ directory should not be
      in main package )

By the way I would appreciate it if you would review my
rubygem related review request (bug 637448)

(In reply to comment #2)
> Some notes:
> 
> * Unused macros
>   - It seems that %ruby_sitelib macro is used nowhere.

Fixed.

> 
> * Requires/BuildRequires
>   - rubygem(rake) is for $ rake test and s.add_development_dependency
>     in gemspec file, so this is not needed for "Requires"
>     (for BuildRequires this is needed).

Fixed.
 
> * Directory ownership issue
>   - The directory %geminstdir itself is not owned by any packages.

Fixed.

> 
> * %files
>   - Please check if %geminstdir/%gemname.gemspec is really needed
>     ( I guess not. Note that gemspec file is also installed under
>       %gemdir/specifications )

Well this file is needed in %check for executing 'rake'. I rather to preserve this file in -doc sub package with tests (if someone want to execute tests, he must be able to do that using 'rake')

> * Document files
>   - I think for this package -doc file should be created and the following
>     entries should be moved to -doc:
> ------------------------------------------------------------------
> %{geminstdir}/test
> %{geminstdir}/Rakefile
> %{geminstdir}/doc
> %{gemdir}/doc/%{gemname}-%{version}
> ------------------------------------------------------------------

Fixed.

Spec URL: http://mifo.sk/RPMS/rubygem-rack-accept.spec
SRPM URL: http://mifo.sk/RPMS/rubygem-rack-accept-0.4.3-3.fc13.src.rpm

Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=251365

Well,

* Please change the release number to 4 to match %changelog
* Please set %defattr(-,root,root,-) on -doc.

---------------------------------------------------------------
   This package (rubygem-rack-accept) is APPROVED by mtasaka
---------------------------------------------------------------

New Package SCM Request
=======================
Package Name:      rubygem-rack-accept
Short Description: HTTP Accept for Ruby/Rack
Owners:            mfojtik
Branches:          f12 f13 f14

Git done (by process-git-requests).

rubygem-rack-accept-0.4.3-4.fc13 has been submitted as an update for Fedora 13.
https://admin.fedoraproject.org/updates/rubygem-rack-accept-0.4.3-4.fc13

rubygem-rack-accept-0.4.3-4.fc14 has been submitted as an update for Fedora 14.
https://admin.fedoraproject.org/updates/rubygem-rack-accept-0.4.3-4.fc14

rubygem-rack-accept-0.4.3-4.fc12 has been submitted as an update for Fedora 12.
https://admin.fedoraproject.org/updates/rubygem-rack-accept-0.4.3-4.fc12

Sorry, would you move README and CHANGES files to main
package?

(In reply to comment #11)
> Sorry, would you move README and CHANGES files to main
> package?

Sure, I'll move those files in next update.

rubygem-rack-accept-0.4.3-4.fc14 has been pushed to the Fedora 14 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update rubygem-rack-accept'.  You can provide feedback for this update here: https://admin.fedoraproject.org/updates/rubygem-rack-accept-0.4.3-4.fc14

Sorry for not noticing the breakage of dependency on
-doc subpackage...

rubygem-rack-accept-0.4.3-5.fc13 has been submitted as an update for Fedora 13.
https://admin.fedoraproject.org/updates/rubygem-rack-accept-0.4.3-5.fc13

rubygem-rack-accept-0.4.3-5.fc14 has been submitted as an update for Fedora 14.
https://admin.fedoraproject.org/updates/rubygem-rack-accept-0.4.3-5.fc14

rubygem-rack-accept-0.4.3-5.fc12 has been submitted as an update for Fedora 12.
https://admin.fedoraproject.org/updates/rubygem-rack-accept-0.4.3-5.fc12

rubygem-rack-accept-0.4.3-5.fc13 has been pushed to the Fedora 13 stable repository.  If problems still persist, please make note of it in this bug report.

rubygem-rack-accept-0.4.3-5.fc14 has been pushed to the Fedora 14 stable repository.  If problems still persist, please make note of it in this bug report.

rubygem-rack-accept-0.4.3-5.fc12 has been pushed to the Fedora 12 stable repository.  If problems still persist, please make note of it in this bug report.