Bug 637448 - Review Request: rubygem-glib2 - Ruby binding of GLib-2.x
Summary: Review Request: rubygem-glib2 - Ruby binding of GLib-2.x
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Michal Fojtik
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 637904 637939 637985 639098 639636 639638
TreeView+ depends on / blocked
 
Reported: 2010-09-25 21:57 UTC by Mamoru TASAKA
Modified: 2010-10-23 16:59 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2010-10-23 16:59:33 UTC
Type: ---
Embargoed:
mfojtik: fedora-review+
kevin: fedora-cvs+


Attachments (Terms of Use)

Description Mamoru TASAKA 2010-09-25 21:57:45 UTC
Spec URL: http://mtasaka.fedorapeople.org/Review_request/rubygem-glib/rubygem-glib2.spec
SRPM URL: http://mtasaka.fedorapeople.org/Review_request/rubygem-glib/rubygem-glib2-0.90.2-0.1.fc.src.rpm
Description: 
Ruby/GLib2 is a Ruby binding of GLib-2.x.

* Note
- Building this srpm requires rubygem-pkg-config (now in dist-f14-override)
  and rubygem-test-unit (now in dist-f14-updates-testing).
  Mock build log for F-14 is available here:
  http://mtasaka.fedorapeople.org/Review_request/rubygem-glib/MOCK-rubygem-glib2.log

Comment 1 Mamoru TASAKA 2010-09-26 18:08:15 UTC
http://mtasaka.fedorapeople.org/Review_request/rubygem-glib/rubygem-glib2.spec
http://mtasaka.fedorapeople.org/Review_request/rubygem-glib/rubygem-glib2-0.90.2-2.fc.src.rpm

* Mon Sep 27 2010 Mamoru Tasaka <mtasaka.u-tokyo.ac.jp> - 0.90.2-2
- 0.90.2 released, release bump

Comment 2 Mamoru TASAKA 2010-09-27 17:00:51 UTC
http://mtasaka.fedorapeople.org/Review_request/rubygem-glib2/rubygem-glib2.spec
http://mtasaka.fedorapeople.org/Review_request/rubygem-glib2/rubygem-glib2-0.90.2-3.fc.src.rpm

* Tue Sep 28 2010 Mamoru Tasaka <mtasaka.u-tokyo.ac.jp> - 0.90.2-3
- Modify Obsoletes

Comment 3 Mamoru TASAKA 2010-09-27 18:39:26 UTC
http://mtasaka.fedorapeople.org/Review_request/rubygem-glib2/rubygem-glib2.spec
http://mtasaka.fedorapeople.org/Review_request/rubygem-glib2/rubygem-glib2-0.90.2-4.fc.src.rpm

* Tue Sep 28 2010 Mamoru Tasaka <mtasaka.u-tokyo.ac.jp> - 0.90.2-4
- Modify Obsoletes
- Fix %%description

Comment 4 Mamoru TASAKA 2010-09-30 17:37:06 UTC
http://mtasaka.fedorapeople.org/Review_request/rubygem-glib2/rubygem-glib2.spec
http://mtasaka.fedorapeople.org/Review_request/rubygem-glib2/rubygem-glib2-0.90.2-5.fc.src.rpm

* Fri Oct  1 2010 Mamoru Tasaka <mtasaka.u-tokyo.ac.jp> - 0.90.2-5
- Use formally released gem file

Comment 5 Mamoru TASAKA 2010-09-30 18:13:35 UTC
http://mtasaka.fedorapeople.org/Review_request/rubygem-glib2/rubygem-glib2.spec
http://mtasaka.fedorapeople.org/Review_request/rubygem-glib2/rubygem-glib2-0.90.2-6.fc.src.rpm

* Fri Oct  1 2010 Mamoru Tasaka <mtasaka.u-tokyo.ac.jp> - 0.90.2-6
- Fix up summary

Comment 6 Michal Fojtik 2010-10-05 12:45:37 UTC
REVIEW:

[OK] Packages that contain Ruby Gems must be called rubygem-%{gemname} where gemname is the name from the Gem's specification.

[OK] The Source of the package must be the full URL to the released Gem archive; the version of the package must be the Gem's version

[OK] The package must have a Requires and a BuildRequires on rubygems

[OK] The package must provide rubygem(%{gemname}) where gemname is the name from the Gem's specification.

[OK] For every dependency on a Gem named gemdep, the package must contain a Requires on rubygem(%{gemdep}) with the same version constraints as the Gem

[OK] The Gem must be installed into %{gemdir} defined as
%global gemdir %(ruby -rubygems -e 'puts Gem::dir' 2>/dev/null)
The install should be performed with the command

gem install --local --install-dir %{buildroot}%{gemdir} --force %{SOURCE0}
The package must own the following files and directories:
%{gemdir}/gems/%{gemname}-%{version}/
%{gemdir}/cache/%{gemname}-%{version}.gem
%{gemdir}/specifications/%{gemname}-%{version}.gemspec

[OK] Architecture-specific content must not be installed into %{gemdir}

[OK] %prep stage must contain %setup -q -c -T to create the directory where C libraries are compiled.

Package looks good, builds without errors/warning under Koji, rpmlint is quite.
Setting REVIEW+

Comment 7 Mamoru TASAKA 2010-10-05 19:00:54 UTC
Thank you!

New Package SCM Request
=======================
Package Name:      rubygem-glib2
Short Description: Ruby bindings of GLib-2.x
Owners:            mtasaka
Branches:          f12 f13 f14

Comment 8 Kevin Fenzi 2010-10-06 23:25:47 UTC
Git done (by process-git-requests).

Comment 9 Mamoru TASAKA 2010-10-07 07:17:58 UTC
Built for f13 f14 (will not build for f12), submitted push
requests on bodhi.

Comment 10 Mamoru TASAKA 2010-10-14 18:08:01 UTC
Now in testing.

Comment 11 Mamoru TASAKA 2010-10-23 16:59:33 UTC
Can be closed.


Note You need to log in before you can comment on or make changes to this bug.