Bug 639617
Summary: | Review Request: rubygem-cucumber-rails - Cucumber Generators and Runtime for Rails | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Michal Fojtik <mfojtik> |
Component: | Package Review | Assignee: | Mamoru TASAKA <mtasaka> |
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | fedora-package-review, notting |
Target Milestone: | --- | Keywords: | Reopened |
Target Release: | --- | Flags: | mtasaka:
fedora-review+
tcallawa: fedora-cvs+ |
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | rubygem-cucumber-rails-0.3.2-5.fc13 | Doc Type: | Bug Fix |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2010-11-04 23:46:25 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Michal Fojtik
2010-10-02 16:04:57 UTC
Additional informations: Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=2508203 $ rpmlint rubygem-cucumber-rails-0.3.2-2.fc13.noarch.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings ! Note Building this rpm requires rubygem-cucumber-0.9.0-4.fc14 (now in testing) for gherkin dependency Some notes * Unused macros - %ruby_sitelib macro is defined but used nowhere. * License - License tag should be "MIT". * Requires ">= 0" is completely redundant. * %files - The directory %geminstdir itself is not owned by any packages - Please consider to create -doc subpackage and move document files to -doc, like: ---------------------------------------------------------- %{geminstdir}/spec %{geminstdir}/dev_tasks %{geminstdir}/Rakefile %{gemdir}/doc/%{gemname}-%{version} %{geminstdir}/%{gemname}.gemspec ---------------------------------------------------------- ! Note that README.rdoc or so should be in main package. By the way I would appreciate it if you would review my review request (bug 637939) * Mon Oct 11 2010 Michal Fojtik <mfojtik@patashnik> - 0.3.2-4 - Moved tests and documentation to doc subpackage - Fixed licence tag - Removed unused macros - Fixed version dependencies Spec URL: http://mifo.sk/RPMS/rubygem-cucumber-rails.spec SRPM URL: http://mifo.sk/RPMS/rubygem-cucumber-rails-0.3.2-4.fc13.src.rpm (In reply to comment #3) > By the way I would appreciate it if you would review my > review request (bug 637939) Sure. (In reply to comment #2) > ! Note > Building this rpm requires rubygem-cucumber-0.9.0-4.fc14 > (now in testing) for gherkin dependency This update has been pushed to stable (In reply to comment #4) > (In reply to comment #2) > > ! Note > > Building this rpm requires rubygem-cucumber-0.9.0-4.fc14 > > (now in testing) for gherkin dependency > > This update has been pushed to stable For F-14, it seems that this is still in -testing. For -4: - Please set %defattr(-,root,root,-) on -doc subpackage. - installed gemspec file says that the dependency for rubygem(cucumber) should be ">= 0.8.0", not ">= 0.9.0". Please fix the above when importing this package into Fedora SCM. ------------------------------------------------ This package (rubygem-cucumber-rails) is approved by mtasaka ------------------------------------------------ Thanks! New Package SCM Request ======================= Package Name: rubygem-cucumber-rails Short Description: Cucumber Generators and Runtime for Rails Owners: mfojtik Branches: f12 f13 f14 Git done (by process-git-requests). rubygem-cucumber-rails-0.3.2-5.fc13 has been submitted as an update for Fedora 13. https://admin.fedoraproject.org/updates/rubygem-cucumber-rails-0.3.2-5.fc13 rubygem-cucumber-rails-0.3.2-5.fc13 has been pushed to the Fedora 13 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update rubygem-cucumber-rails'. You can provide feedback for this update here: https://admin.fedoraproject.org/updates/rubygem-cucumber-rails-0.3.2-5.fc13 Closing. Oops, reverting (as F-14 is not built yet) Please rebuild this also on F-14 rubygem-cucumber-rails-0.3.2-5.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report. |