Bug 639617 - Review Request: rubygem-cucumber-rails - Cucumber Generators and Runtime for Rails
Summary: Review Request: rubygem-cucumber-rails - Cucumber Generators and Runtime for ...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Mamoru TASAKA
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2010-10-02 16:04 UTC by Michal Fojtik
Modified: 2010-11-04 23:46 UTC (History)
2 users (show)

Fixed In Version: rubygem-cucumber-rails-0.3.2-5.fc13
Clone Of:
Environment:
Last Closed: 2010-11-04 23:46:25 UTC
Type: ---
Embargoed:
mtasaka: fedora-review+
tcallawa: fedora-cvs+


Attachments (Terms of Use)

Description Michal Fojtik 2010-10-02 16:04:57 UTC
Spec URL: http://mifo.sk/RPMS/rubygem-cucumber-rails.spec
SRPM URL: http://mifo.sk/RPMS/rubygem-cucumber-rails-0.3.2-3.fc13.src.rpm
Description: 

Cucumber-Rails brings Cucumber to Rails2 and Rails3. It contains 2 generators - one for bootstrapping your Rails app for Cucumber, and a second one for generating features.

Comment 1 Michal Fojtik 2010-10-02 16:05:52 UTC
Additional informations:

Koji build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=2508203

$ rpmlint rubygem-cucumber-rails-0.3.2-2.fc13.noarch.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings

Comment 2 Mamoru TASAKA 2010-10-08 17:57:22 UTC
! Note
  Building this rpm requires rubygem-cucumber-0.9.0-4.fc14
  (now in testing) for gherkin dependency

Some notes
* Unused macros
  - %ruby_sitelib macro is defined but used nowhere.

* License
  - License tag should be "MIT".

* Requires
  ">= 0" is completely redundant.

* %files
  - The directory %geminstdir itself is not owned by any packages
  - Please consider to create -doc subpackage and move document
    files to -doc, like:
----------------------------------------------------------
%{geminstdir}/spec
%{geminstdir}/dev_tasks
%{geminstdir}/Rakefile
%{gemdir}/doc/%{gemname}-%{version}
%{geminstdir}/%{gemname}.gemspec
----------------------------------------------------------
    ! Note that README.rdoc or so should be in main package.

Comment 3 Mamoru TASAKA 2010-10-08 18:01:44 UTC
By the way I would appreciate it if you would review my
review request (bug 637939)

Comment 4 Michal Fojtik 2010-10-11 12:28:16 UTC

* Mon Oct 11 2010 Michal Fojtik <mfojtik@patashnik> - 0.3.2-4
- Moved tests and documentation to doc subpackage
- Fixed licence tag
- Removed unused macros
- Fixed version dependencies

Spec URL: http://mifo.sk/RPMS/rubygem-cucumber-rails.spec
SRPM URL: http://mifo.sk/RPMS/rubygem-cucumber-rails-0.3.2-4.fc13.src.rpm



(In reply to comment #3)
> By the way I would appreciate it if you would review my
> review request (bug 637939)

Sure.

(In reply to comment #2)
> ! Note
>   Building this rpm requires rubygem-cucumber-0.9.0-4.fc14
>   (now in testing) for gherkin dependency

This update has been pushed to stable

Comment 5 Mamoru TASAKA 2010-10-11 19:23:33 UTC
(In reply to comment #4)
> (In reply to comment #2)
> > ! Note
> >   Building this rpm requires rubygem-cucumber-0.9.0-4.fc14
> >   (now in testing) for gherkin dependency
> 
> This update has been pushed to stable

For F-14, it seems that this is still in -testing.

For -4:

- Please set %defattr(-,root,root,-) on -doc subpackage.
- installed gemspec file says that the dependency for
  rubygem(cucumber) should be ">= 0.8.0", not ">= 0.9.0".

Please fix the above when importing this package into
Fedora SCM.

------------------------------------------------
    This package (rubygem-cucumber-rails) is
    approved by mtasaka
------------------------------------------------

Comment 6 Michal Fojtik 2010-10-12 10:54:52 UTC
Thanks!

New Package SCM Request
=======================
Package Name:       rubygem-cucumber-rails
Short Description:  Cucumber Generators and Runtime for Rails
Owners:             mfojtik
Branches:           f12 f13 f14

Comment 7 Tom "spot" Callaway 2010-10-13 15:15:19 UTC
Git done (by process-git-requests).

Comment 8 Fedora Update System 2010-10-14 10:38:26 UTC
rubygem-cucumber-rails-0.3.2-5.fc13 has been submitted as an update for Fedora 13.
https://admin.fedoraproject.org/updates/rubygem-cucumber-rails-0.3.2-5.fc13

Comment 9 Fedora Update System 2010-10-14 22:59:35 UTC
rubygem-cucumber-rails-0.3.2-5.fc13 has been pushed to the Fedora 13 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update rubygem-cucumber-rails'.  You can provide feedback for this update here: https://admin.fedoraproject.org/updates/rubygem-cucumber-rails-0.3.2-5.fc13

Comment 10 Mamoru TASAKA 2010-10-20 17:12:51 UTC
Closing.

Comment 11 Mamoru TASAKA 2010-10-20 17:13:43 UTC
Oops, reverting (as F-14 is not built yet)

Comment 12 Mamoru TASAKA 2010-10-29 17:35:47 UTC
Please rebuild this also on F-14

Comment 13 Fedora Update System 2010-11-04 23:46:21 UTC
rubygem-cucumber-rails-0.3.2-5.fc13 has been pushed to the Fedora 13 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.