Bug 639684
| Summary: | Review Request: perl-Pegex - Pegex Parser Generator | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Gerd Pokorra <gp> |
| Component: | Package Review | Assignee: | Marcela Mašláňová <mmaslano> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, notting |
| Target Milestone: | --- | Flags: | mmaslano:
fedora-review+
petersen: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | http://search.cpan.org/dist/Pegex/ | ||
| Whiteboard: | |||
| Fixed In Version: | perl-Pegex-0.11-1.fc14 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2010-11-05 22:58:17 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Gerd Pokorra
2010-10-03 10:48:55 UTC
- package meets naming guidelines OK
- package meets packaging guidelines OK
- license (GPL+ or Artistic) OK, text in %doc, matches source OK
- spec file legible, in am. english OK
- source matches upstream OK
- package compiles on devel (x86) OK
- no missing BR OK
- no unnecessary BR !OK
- no locales OK
- not relocatable OK
- owns all directories that it creates OK
- no duplicate files OK
- permissions ok OK
- %clean ok OK
- macro use consistent OK
- code, not content OK
- no need for -docs OK
- nothing in %doc affects runtime OK
- no need for .desktop file OK
Not needed:
BuildRequires: perl >= 1:5.8.3
BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
^ you don't need specify Buildroot for F-13 and higher and EL-6
perl-Pegex.src: W: invalid-url Source0: http://search.cpan.org/CPAN/authors/id/I/IN/INGY/Pegex-0.10.tar.gz <urlopen error timed out>
Not sure what's wrong, this link worked for me.
The link ftp://ftp.uni-siegen.de/pub/review/perl-Pegex.spec is updated to ftp://ftp.uni-siegen.de/pub/review/perl-Pegex.spec.2 The new SRPM is: ftp://ftp.uni-siegen.de/pub/review/perl-Pegex-0.11-1.fc13.src.rpm Is it necessary to remove the buildroot? The package build without it but rpmlint gives out a warning. The message "urlopen error timed out" I get only sometimes. The server seems to be to slow from time to time. I am in a hurry. Scratch build URLs I can add later if they are needed. koji build in rawhide passed: http://koji.fedoraproject.org/koji/taskinfo?taskID=2557443 No, the buildroot could stay there, but it's not needed. New Package SCM Request ======================= Package Name: perl-Pegex Short Description: Pegex Parser Generator Owners: gerd Branches: f13 f14 el6 InitialCC: gerd Git done (by process-git-requests). perl-Pegex-0.11-1.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/perl-Pegex-0.11-1.fc14 perl-Pegex-0.11-1.fc13 has been submitted as an update for Fedora 13. https://admin.fedoraproject.org/updates/perl-Pegex-0.11-1.fc13 perl-Pegex-0.11-1.fc14 has been pushed to the Fedora 14 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update perl-Pegex'. You can provide feedback for this update here: https://admin.fedoraproject.org/updates/perl-Pegex-0.11-1.fc14 perl-Pegex-0.11-1.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report. perl-Pegex-0.11-1.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report. |