Bug 639684 - Review Request: perl-Pegex - Pegex Parser Generator
Summary: Review Request: perl-Pegex - Pegex Parser Generator
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Marcela Mašláňová
QA Contact: Fedora Extras Quality Assurance
URL: http://search.cpan.org/dist/Pegex/
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2010-10-03 10:48 UTC by Gerd Pokorra
Modified: 2010-11-05 22:58 UTC (History)
2 users (show)

Fixed In Version: perl-Pegex-0.11-1.fc14
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2010-11-05 22:58:17 UTC
Type: ---
Embargoed:
mmaslano: fedora-review+
petersen: fedora-cvs+


Attachments (Terms of Use)

Description Gerd Pokorra 2010-10-03 10:48:55 UTC
Spec URL: ftp://ftp.uni-siegen.de/pub/review/perl-Pegex.spec
SRPM URL: ftp://ftp.uni-siegen.de/pub/review/perl-Pegex-0.10-1.fc13.src.rpm

Description:
Pegex is a Acmeist parser framework. It is a PEG parser grammar syntax,
combined with PCRE compatible regular expressions as the match tokens.
Pegex draws heavily from Perl 6 rules, but works equivalently in many
modern programming languages.

The rpmlint output from the specfile, binary rpm and source rpm is without errors and warnings.

Successfully completed scratch builds for F13 - F15 are at:

F15-URL: http://koji.fedoraproject.org/koji/taskinfo?taskID=2508862
F14-URL: http://koji.fedoraproject.org/koji/taskinfo?taskID=2508860
F13-URL: http://koji.fedoraproject.org/koji/taskinfo?taskID=2508854

It should be a easy to review package.

Comment 1 Marcela Mašláňová 2010-10-27 14:08:54 UTC
- package meets naming guidelines OK
- package meets packaging guidelines OK
- license (GPL+ or Artistic) OK, text in %doc, matches source OK
- spec file legible, in am. english OK
- source matches upstream OK
- package compiles on devel (x86) OK
- no missing BR OK
- no unnecessary BR !OK
- no locales OK
- not relocatable OK
- owns all directories that it creates OK
- no duplicate files OK
- permissions ok OK
- %clean ok OK
- macro use consistent OK
- code, not content OK
- no need for -docs OK
- nothing in %doc affects runtime OK
- no need for .desktop file  OK

Not needed:
BuildRequires:  perl >= 1:5.8.3
BuildRoot:      %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
^ you don't need specify Buildroot for F-13 and higher and EL-6

perl-Pegex.src: W: invalid-url Source0: http://search.cpan.org/CPAN/authors/id/I/IN/INGY/Pegex-0.10.tar.gz <urlopen error timed out>
Not sure what's wrong, this link worked for me.

Comment 2 Gerd Pokorra 2010-10-27 15:45:07 UTC
The link

ftp://ftp.uni-siegen.de/pub/review/perl-Pegex.spec

is updated to

ftp://ftp.uni-siegen.de/pub/review/perl-Pegex.spec.2

The new SRPM is:

ftp://ftp.uni-siegen.de/pub/review/perl-Pegex-0.11-1.fc13.src.rpm


Is it necessary to remove the buildroot? The package build without it but rpmlint gives out a warning.
The message "urlopen error timed out" I get only sometimes. The server seems to be to slow from time to time.

I am in a hurry. Scratch build URLs I can add later if they are needed.

Comment 3 Marcela Mašláňová 2010-10-27 16:15:26 UTC
koji build in rawhide passed:
http://koji.fedoraproject.org/koji/taskinfo?taskID=2557443

No, the buildroot could stay there, but it's not needed.

Comment 4 Gerd Pokorra 2010-10-28 07:24:58 UTC
New Package SCM Request
=======================
Package Name: perl-Pegex
Short Description: Pegex Parser Generator
Owners: gerd
Branches: f13 f14 el6
InitialCC: gerd

Comment 5 Jens Petersen 2010-10-28 09:11:43 UTC
Git done (by process-git-requests).

Comment 6 Fedora Update System 2010-10-28 11:39:18 UTC
perl-Pegex-0.11-1.fc14 has been submitted as an update for Fedora 14.
https://admin.fedoraproject.org/updates/perl-Pegex-0.11-1.fc14

Comment 7 Fedora Update System 2010-10-28 13:06:14 UTC
perl-Pegex-0.11-1.fc13 has been submitted as an update for Fedora 13.
https://admin.fedoraproject.org/updates/perl-Pegex-0.11-1.fc13

Comment 8 Fedora Update System 2010-10-28 22:17:02 UTC
perl-Pegex-0.11-1.fc14 has been pushed to the Fedora 14 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update perl-Pegex'.  You can provide feedback for this update here: https://admin.fedoraproject.org/updates/perl-Pegex-0.11-1.fc14

Comment 9 Fedora Update System 2010-11-05 22:58:12 UTC
perl-Pegex-0.11-1.fc13 has been pushed to the Fedora 13 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 10 Fedora Update System 2010-11-05 22:58:29 UTC
perl-Pegex-0.11-1.fc14 has been pushed to the Fedora 14 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.