Bug 639980

Summary: Traceback when trying delete/update key value for a non existent key with pulp-admin consumer
Product: [Retired] Pulp Reporter: Preethi Thomas <pthomas>
Component: z_otherAssignee: Sayli Karmarkar <skarmark>
Status: CLOSED CURRENTRELEASE QA Contact: Preethi Thomas <pthomas>
Severity: medium Docs Contact:
Priority: low    
Version: unspecifiedCC: cperry
Target Milestone: ---Keywords: Triaged
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2011-02-17 16:51:42 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 647488    

Description Preethi Thomas 2010-10-04 13:30:20 UTC
Description of problem:

Try to run pulp-admin consumer update_keyvalue for key that does not exist


[root@preethi ~]# pulp-admin consumer update_keyvalue --id=preethi.usersys.redhat.com --key=test_key1 --value=preethi2
"Traceback (most recent call last):\n  File \"/usr/lib/python2.6/site-packages/pulp/server/webservices/controllers/base.py\", line 51, in report_error\n    return method(self, *args, **kwargs)\n  File \"/usr/lib/python2.6/site-packages/pulp/server/webservices/controllers/consumers.py\", line 386, in POST\n    return action(id)\n  File \"/usr/lib/python2.6/site-packages/pulp/server/webservices/role_check.py\", line 102, in check_roles\n    result = f(instance, *fargs, **kw)\n  File \"/usr/lib/python2.6/site-packages/pulp/server/webservices/controllers/consumers.py\", line 283, in update_key_value_pair\n    consumer_api.update_key_value_pair(id, data['key'], data['value'])\n  File \"/usr/lib/python2.6/site-packages/pulp/server/auditing.py\", line 193, in _audit\n    result = method(*args, **kwargs)\n  File \"/usr/lib/python2.6/site-packages/pulp/server/api/consumer.py\", line 166, in update_key_value_pair\n    raise PulpException('Given key [%s] does not exist', key)\nPulpException: u'Given key [test_key1] does not exist'\n"
[root@preethi ~]#

Comment 1 Preethi Thomas 2010-10-04 13:39:59 UTC
Also deleting a non-existent key
[root@preethi ~]# pulp-admin consumer delete_keyvalue --id=preethi.usersys.redhat.com --key=test_key
"Traceback (most recent call last):\n  File \"/usr/lib/python2.6/site-packages/pulp/server/webservices/controllers/base.py\", line 51, in report_error\n    return method(self, *args, **kwargs)\n  File \"/usr/lib/python2.6/site-packages/pulp/server/webservices/controllers/consumers.py\", line 386, in POST\n    return action(id)\n  File \"/usr/lib/python2.6/site-packages/pulp/server/webservices/role_check.py\", line 102, in check_roles\n    result = f(instance, *fargs, **kw)\n  File \"/usr/lib/python2.6/site-packages/pulp/server/webservices/controllers/consumers.py\", line 272, in delete_key_value_pair\n    consumer_api.delete_key_value_pair(id, data)\n  File \"/usr/lib/python2.6/site-packages/pulp/server/auditing.py\", line 193, in _audit\n    result = method(*args, **kwargs)\n  File \"/usr/lib/python2.6/site-packages/pulp/server/api/consumer.py\", line 145, in delete_key_value_pair\n    raise PulpException('Given key [%s] does not exist', key)\nPulpException: u'Given key [test_key] does not exist'\n"

Comment 2 Sayli Karmarkar 2010-11-01 07:25:22 UTC
$ sudo pulp-admin consumer delete_keyvalue --id=consumer1 --key=key2
Successfully deleted key: key2

$ sudo pulp-admin consumer delete_keyvalue --id=consumer1 --key=key3
error: operation failed: "Given key [key3] does not exist"

Same error handling added for add and update as well.

Comment 3 Jay Dobies 2010-11-03 19:35:17 UTC
Fixed in build 0.78.

Comment 4 Preethi Thomas 2010-11-08 15:50:37 UTC
verified


[root@preethi ~]# pulp-admin consumer update_keyvalue --id=preethi.usersys.redhat.com  --key=country2 --value=us2
error: operation failed: "Given key [country2] does not exist"

Comment 5 Preethi Thomas 2011-02-17 16:51:42 UTC
Closing with community release 

pulp-0.0.139-1.fc14.noarch