Bug 639980 - Traceback when trying delete/update key value for a non existent key with pulp-admin consumer
Summary: Traceback when trying delete/update key value for a non existent key with pul...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Pulp
Classification: Retired
Component: z_other
Version: unspecified
Hardware: All
OS: Linux
low
medium
Target Milestone: ---
: ---
Assignee: Sayli Karmarkar
QA Contact: Preethi Thomas
URL:
Whiteboard:
Depends On:
Blocks: verified-to-close
TreeView+ depends on / blocked
 
Reported: 2010-10-04 13:30 UTC by Preethi Thomas
Modified: 2015-03-23 01:10 UTC (History)
1 user (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2011-02-17 16:51:42 UTC
Embargoed:


Attachments (Terms of Use)

Description Preethi Thomas 2010-10-04 13:30:20 UTC
Description of problem:

Try to run pulp-admin consumer update_keyvalue for key that does not exist


[root@preethi ~]# pulp-admin consumer update_keyvalue --id=preethi.usersys.redhat.com --key=test_key1 --value=preethi2
"Traceback (most recent call last):\n  File \"/usr/lib/python2.6/site-packages/pulp/server/webservices/controllers/base.py\", line 51, in report_error\n    return method(self, *args, **kwargs)\n  File \"/usr/lib/python2.6/site-packages/pulp/server/webservices/controllers/consumers.py\", line 386, in POST\n    return action(id)\n  File \"/usr/lib/python2.6/site-packages/pulp/server/webservices/role_check.py\", line 102, in check_roles\n    result = f(instance, *fargs, **kw)\n  File \"/usr/lib/python2.6/site-packages/pulp/server/webservices/controllers/consumers.py\", line 283, in update_key_value_pair\n    consumer_api.update_key_value_pair(id, data['key'], data['value'])\n  File \"/usr/lib/python2.6/site-packages/pulp/server/auditing.py\", line 193, in _audit\n    result = method(*args, **kwargs)\n  File \"/usr/lib/python2.6/site-packages/pulp/server/api/consumer.py\", line 166, in update_key_value_pair\n    raise PulpException('Given key [%s] does not exist', key)\nPulpException: u'Given key [test_key1] does not exist'\n"
[root@preethi ~]#

Comment 1 Preethi Thomas 2010-10-04 13:39:59 UTC
Also deleting a non-existent key
[root@preethi ~]# pulp-admin consumer delete_keyvalue --id=preethi.usersys.redhat.com --key=test_key
"Traceback (most recent call last):\n  File \"/usr/lib/python2.6/site-packages/pulp/server/webservices/controllers/base.py\", line 51, in report_error\n    return method(self, *args, **kwargs)\n  File \"/usr/lib/python2.6/site-packages/pulp/server/webservices/controllers/consumers.py\", line 386, in POST\n    return action(id)\n  File \"/usr/lib/python2.6/site-packages/pulp/server/webservices/role_check.py\", line 102, in check_roles\n    result = f(instance, *fargs, **kw)\n  File \"/usr/lib/python2.6/site-packages/pulp/server/webservices/controllers/consumers.py\", line 272, in delete_key_value_pair\n    consumer_api.delete_key_value_pair(id, data)\n  File \"/usr/lib/python2.6/site-packages/pulp/server/auditing.py\", line 193, in _audit\n    result = method(*args, **kwargs)\n  File \"/usr/lib/python2.6/site-packages/pulp/server/api/consumer.py\", line 145, in delete_key_value_pair\n    raise PulpException('Given key [%s] does not exist', key)\nPulpException: u'Given key [test_key] does not exist'\n"

Comment 2 Sayli Karmarkar 2010-11-01 07:25:22 UTC
$ sudo pulp-admin consumer delete_keyvalue --id=consumer1 --key=key2
Successfully deleted key: key2

$ sudo pulp-admin consumer delete_keyvalue --id=consumer1 --key=key3
error: operation failed: "Given key [key3] does not exist"

Same error handling added for add and update as well.

Comment 3 Jay Dobies 2010-11-03 19:35:17 UTC
Fixed in build 0.78.

Comment 4 Preethi Thomas 2010-11-08 15:50:37 UTC
verified


[root@preethi ~]# pulp-admin consumer update_keyvalue --id=preethi.usersys.redhat.com  --key=country2 --value=us2
error: operation failed: "Given key [country2] does not exist"

Comment 5 Preethi Thomas 2011-02-17 16:51:42 UTC
Closing with community release 

pulp-0.0.139-1.fc14.noarch


Note You need to log in before you can comment on or make changes to this bug.