Bug 643332
| Summary: | Review Request: notmuch - System for indexing, searching, and tagging email | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Karel Klíč <kklic> |
| Component: | Package Review | Assignee: | Jan Kaluža <jkaluza> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, jkaluza, jonathan.underwood, lmacken, notting, rvokal |
| Target Milestone: | --- | Keywords: | Reopened |
| Target Release: | --- | Flags: | jkaluza:
fedora-review+
|
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2015-09-16 22:50:55 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Karel Klíč
2010-10-15 10:42:51 UTC
Spec URL: http://kklic.fedorapeople.org/notmuch.spec SRPM URL: http://kklic.fedorapeople.org/notmuch-0.5-1.fc12.src.rpm * Mon Nov 15 2010 Karel Klic <kklic> - 0.5-1 - New upstream release rpmlint shows only warnings which are not blocker.
Formal review according to Review Guidelines:
Explanation:
[ok] .... the package meets the guideline item
[--] .... the guideline item is not relevant for this package
[ERR] ... the package fails to meet the guideline and must be fixed.
====================
[ok] rpmlint must be run on every package.
[ok] named according to the Package Naming Guidelines.
[ok] The spec file name must match the base package %{name}
[ok] License must be Fedora approved; Licensing Guidelines.
[ok] The License field in the package spec file must match the actual license.
[ok] license file must packaged in %doc.
[ok] spec file in American English.
[ok] spec legible.
[ok] sources must match the upstream source
[ok] must compile and build.
[--] ExcludeArch if it does not.
[ok] complete and sensible BuildRequires
[--] handling of locales
[ok] ldconfig for dynamic libs
[ok] Packages must NOT bundle copies of system libraries.
[--] rules for relocatable packages
[ok] directory ownership
[ok] no duplicate listing in %files
[ok] sane permissions; %defattr(...)
[ok] consistent macro usage
[ok] code or permissable content
[ok] large doc
[ok] header files
[--] static libs
[ok] .so in -devel
[ok] devel requires base package
[--] remove .la files
[--] GUI app must include a %{name}.desktop and use desktop-file-install
[ok] no owning of other packages' files/dirs
[ok] UTF-8 filenames
Formal review according to Packaging Guidelines:
[ok] naming
[ok] version and release
[ok] Licensing
[ok] no inclusion of pre-built binaries or libraries
[ok] spec legibility
[ok] arch support
[ok] filesystem layout
[ok] changelogs
[ok] tags
[ok] BuildRoot
[ok] Requires
[ok] BuildRequires
[ok] summary and description
[ok] encoding
[ok] compiler flags
[ok] debuginfo
[ok] devel packages
[ok] no duplication of system libraries
[ok] no rpath
[ok] config files
[--] initscripts
[--] desktop files
[--] Icon tag in Desktop Files
[ok] macros
[--] handling locale files
[ok] timestamps
[ok] parallel make
[--] scriptlets
[--] conditional deps
[--] relocatable packages
[ok] code vs content
[ok] file and dir ownership
[--] users and groups
[ok] web apps
[ok] no conflicts
[ok] no kernel modules
[ok] nothing in /srv
[ok] no bundling
[ok] no fonts bundling
[--] epoch
[ok] symlinks
[ok] man pages
I think the package is OK, builds find in koji, works well for me.
Consider the package APPROVED.
New Package SCM Request ======================= Package Name: notmuch Short Description: system for indexing, searching, and tagging email Owners: kklic Branches: f13 f14 InitialCC: Git done (by process-git-requests). notmuch-0.5-1.fc13 has been submitted as an update for Fedora 13. https://admin.fedoraproject.org/updates/notmuch-0.5-1.fc13 notmuch-0.5-1.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/notmuch-0.5-1.fc14 Jan, thank you for the review. notmuch-0.5-1.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report. notmuch-0.5-1.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report. Package Change Request ====================== Package Name: notmuch New Branches: el6 epel7 Owners: lmacken ndevos ndevos is not a member of the Packager group. |