Bug 643332 - Review Request: notmuch - System for indexing, searching, and tagging email
Summary: Review Request: notmuch - System for indexing, searching, and tagging email
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jan Kaluža
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2010-10-15 10:42 UTC by Karel Klíč
Modified: 2015-09-16 22:50 UTC (History)
6 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2015-09-16 22:50:55 UTC
Type: ---
Embargoed:
jkaluza: fedora-review+


Attachments (Terms of Use)

Description Karel Klíč 2010-10-15 10:42:51 UTC
Spec URL: http://kklic.fedorapeople.org/notmuch.spec
SRPM URL: http://kklic.fedorapeople.org/notmuch-0.3.1-1.fc12.src.rpm
Description: 
Fast system for indexing, searching, and tagging email.  Even if you
receive 12000 messages per month or have on the order of millions of
messages that you've been saving for decades, Notmuch will be able to
quickly search all of it.

Notmuch is not much of an email program. It doesn't receive messages
(no POP or IMAP support). It doesn't send messages (no mail composer,
no network code at all). And for what it does do (email search) that
work is provided by an external library, Xapian. So if Notmuch
provides no user interface and Xapian does all the heavy lifting, then
what's left here? Not much.


$ rpmlint notmuch.spec
0 packages and 1 specfiles checked; 0 errors, 0 warnings.

Architecture-dependent packages:
[karel@agata i386]$ rpmlint *
notmuch-devel.i386: W: no-documentation
notmuch.i386: W: shared-lib-calls-exit /usr/lib/libnotmuch.so.1.1.0 exit
notmuch.i386: W: non-conffile-in-etc /etc/bash_completion.d/notmuch
3 packages and 0 specfiles checked; 0 errors, 3 warnings.

Noarch packages:
[karel@agata noarch]$ rpmlint *
emacs-notmuch-el.noarch: W: spelling-error Summary(en_US) Elisp -> Elis, Lisp, Elise
emacs-notmuch-el.noarch: W: spelling-error %description -l en_US Elisp -> Elis, Lisp, Elise
emacs-notmuch-el.noarch: W: no-documentation
emacs-notmuch.noarch: W: no-documentation
2 packages and 0 specfiles checked; 0 errors, 4 warnings.

Comment 1 Karel Klíč 2010-11-15 18:06:22 UTC
Spec URL: http://kklic.fedorapeople.org/notmuch.spec
SRPM URL: http://kklic.fedorapeople.org/notmuch-0.5-1.fc12.src.rpm

* Mon Nov 15 2010 Karel Klic <kklic> - 0.5-1
- New upstream release

Comment 2 Jan Kaluža 2010-11-22 11:47:17 UTC
rpmlint shows only warnings which are not blocker.

Formal review according to Review Guidelines:
Explanation:
[ok] .... the package meets the guideline item
[--] .... the guideline item is not relevant for this package
[ERR] ... the package fails to meet the guideline and must be fixed.
====================

[ok] rpmlint must be run on every package.
[ok] named according to the Package Naming Guidelines.
[ok] The spec file name must match the base package %{name}
[ok] License must be Fedora approved; Licensing Guidelines.
[ok] The License field in the package spec file must match the actual license.
[ok] license file must packaged in %doc.
[ok] spec file in American English.
[ok] spec legible.
[ok] sources must match the upstream source
[ok] must compile and build.
[--] ExcludeArch if it does not.
[ok] complete and sensible BuildRequires
[--] handling of locales
[ok] ldconfig for dynamic libs
[ok] Packages must NOT bundle copies of system libraries.
[--] rules for relocatable packages
[ok] directory ownership
[ok] no duplicate listing in %files
[ok] sane permissions; %defattr(...)
[ok] consistent macro usage
[ok] code or permissable content
[ok] large doc
[ok] header files
[--] static libs
[ok] .so in -devel
[ok] devel requires base package
[--] remove .la files
[--] GUI app must include a %{name}.desktop and use desktop-file-install
[ok] no owning of other packages' files/dirs
[ok] UTF-8 filenames

Formal review according to Packaging Guidelines:

[ok] naming
[ok] version and release
[ok] Licensing
[ok] no inclusion of pre-built binaries or libraries
[ok] spec legibility
[ok] arch support
[ok] filesystem layout
[ok] changelogs
[ok] tags
[ok] BuildRoot
[ok] Requires
[ok] BuildRequires
[ok] summary and description
[ok] encoding
[ok] compiler flags
[ok] debuginfo
[ok] devel packages
[ok] no duplication of system libraries
[ok] no rpath
[ok] config files
[--] initscripts
[--] desktop files
[--] Icon tag in Desktop Files
[ok] macros
[--] handling locale files
[ok] timestamps
[ok] parallel make
[--] scriptlets
[--] conditional deps
[--] relocatable packages
[ok] code vs content
[ok] file and dir ownership
[--] users and groups
[ok] web apps
[ok] no conflicts
[ok] no kernel modules
[ok] nothing in /srv
[ok] no bundling
[ok] no fonts bundling
[--] epoch
[ok] symlinks
[ok] man pages

I think the package is OK, builds find in koji, works well for me.

Consider the package APPROVED.

Comment 3 Karel Klíč 2010-11-23 18:21:55 UTC
New Package SCM Request
=======================
Package Name: notmuch
Short Description: system for indexing, searching, and tagging email
Owners: kklic
Branches: f13 f14
InitialCC:

Comment 4 Jason Tibbitts 2010-11-24 20:31:20 UTC
Git done (by process-git-requests).

Comment 5 Fedora Update System 2010-11-25 11:03:46 UTC
notmuch-0.5-1.fc13 has been submitted as an update for Fedora 13.
https://admin.fedoraproject.org/updates/notmuch-0.5-1.fc13

Comment 6 Fedora Update System 2010-11-25 11:03:54 UTC
notmuch-0.5-1.fc14 has been submitted as an update for Fedora 14.
https://admin.fedoraproject.org/updates/notmuch-0.5-1.fc14

Comment 7 Karel Klíč 2010-11-25 11:04:56 UTC
Jan, thank you for the review.

Comment 8 Fedora Update System 2010-12-07 20:10:40 UTC
notmuch-0.5-1.fc13 has been pushed to the Fedora 13 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 9 Fedora Update System 2010-12-07 20:10:54 UTC
notmuch-0.5-1.fc14 has been pushed to the Fedora 14 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 10 Luke Macken 2014-08-29 18:31:13 UTC
Package Change Request
======================
Package Name: notmuch
New Branches: el6 epel7
Owners: lmacken ndevos

Comment 11 Gwyn Ciesla 2014-09-02 12:51:03 UTC
ndevos is not a member of the Packager group.


Note You need to log in before you can comment on or make changes to this bug.