Bug 643391
| Summary: | Review Request: pytrailer - Python module to simplify access to movies on apple.com/trailers | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Stanislav Ochotnicky <sochotni> |
| Component: | Package Review | Assignee: | Petr Šabata <psabata> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, notting, psabata |
| Target Milestone: | --- | Flags: | psabata:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2010-10-21 13:58:26 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 643392 | ||
|
Description
Stanislav Ochotnicky
2010-10-15 13:33:12 UTC
rpmlint results seem okay (although the output is different for RPMs and SPEC; might be an rpmlint issue): $ rpmlint pytrailer-0.3.1-1.fc13.noarch.rpm pytrailer.noarch: W: spelling-error %description -l en_US www -> WWW, waw, wow 1 packages and 0 specfiles checked; 0 errors, 1 warnings. $ rpmlint pytrailer-0.3.1-1.fc13.src.rpm pytrailer.src: W: spelling-error %description -l en_US www -> WWW, waw, wow 1 packages and 0 specfiles checked; 0 errors, 1 warnings. $ rpmlint pytrailer.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. The package name is okay. The SPEC file name matches the package name and its %name. The package uses an approved license (LGPLv2) and seems legible. Provided SRPM sources match the upstream sources. Package builds fine (noarch). BuildRequires looks legit. The %files section lists files correctly. The package meets the packaging guidelines. Issues: Don't mix RPM macros and variables. Change $RPM_BUILD_ROOT to %buildroot. Upstream version license is LGPLv3 but the SPEC files states it's LGPLv2. * Fri Oct 15 2010 Stanislav Ochotnicky <sochotnicky> - 0.3.1-2 - Fix License tag to match license of the package - Change RPM_BUILD_ROOT to buildroot macro Spec URL: http://sochotni.fedorapeople.org/packages/pytrailer.spec SRPM URL: http://sochotni.fedorapeople.org/packages/pytrailer-0.3.1-2.fc13.src.rpm It looks okay now. New Package CVS Request ======================= Package Name: pytrailer Short Description: Python module to simplify access to movie trailers on apple.com Owners: sochotni Branches: f12 f13 f14 InitialCC: Git done (by process-git-requests). Thanks for review & scm. Package built, closing. http://koji.fedoraproject.org/koji/taskinfo?taskID=2546648 |