Spec URL: http://sochotni.fedorapeople.org/packages/pytrailer.spec SRPM URL: http://sochotni.fedorapeople.org/packages/pytrailer-0.3.1-1.fc13.src.rpm Description: Pytrailer is very simple python module using JSON and few simple regular expressions to simplify access to trailer information on www.apple.com/trailers.
rpmlint results seem okay (although the output is different for RPMs and SPEC; might be an rpmlint issue): $ rpmlint pytrailer-0.3.1-1.fc13.noarch.rpm pytrailer.noarch: W: spelling-error %description -l en_US www -> WWW, waw, wow 1 packages and 0 specfiles checked; 0 errors, 1 warnings. $ rpmlint pytrailer-0.3.1-1.fc13.src.rpm pytrailer.src: W: spelling-error %description -l en_US www -> WWW, waw, wow 1 packages and 0 specfiles checked; 0 errors, 1 warnings. $ rpmlint pytrailer.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. The package name is okay. The SPEC file name matches the package name and its %name. The package uses an approved license (LGPLv2) and seems legible. Provided SRPM sources match the upstream sources. Package builds fine (noarch). BuildRequires looks legit. The %files section lists files correctly. The package meets the packaging guidelines. Issues: Don't mix RPM macros and variables. Change $RPM_BUILD_ROOT to %buildroot. Upstream version license is LGPLv3 but the SPEC files states it's LGPLv2.
* Fri Oct 15 2010 Stanislav Ochotnicky <sochotnicky> - 0.3.1-2 - Fix License tag to match license of the package - Change RPM_BUILD_ROOT to buildroot macro Spec URL: http://sochotni.fedorapeople.org/packages/pytrailer.spec SRPM URL: http://sochotni.fedorapeople.org/packages/pytrailer-0.3.1-2.fc13.src.rpm
It looks okay now.
New Package CVS Request ======================= Package Name: pytrailer Short Description: Python module to simplify access to movie trailers on apple.com Owners: sochotni Branches: f12 f13 f14 InitialCC:
Git done (by process-git-requests).
Thanks for review & scm. Package built, closing. http://koji.fedoraproject.org/koji/taskinfo?taskID=2546648