Bug 644883
| Summary: | Review Request: django-simple-captcha - Django application to add captcha images to any Django form. | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | David Riches <david.r> |
| Component: | Package Review | Assignee: | Hiemanshu Sharma <hiemanshu> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, herlo1, hiemanshu, notting |
| Target Milestone: | --- | Flags: | hiemanshu:
fedora-review+
j: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | django-simple-captcha-0.2.0-4.fc14 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2010-10-21 14:11:41 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
David Riches
2010-10-20 14:30:39 UTC
http://koji.fedoraproject.org/koji/taskinfo?taskID=2544899 Koji scratch build link Taking this for review. bumped spec, fixed folder permissions new src.rpm.. http://dcr226.fedorapeople.org/SRPMS/django-simple-captcha-0.2.0-3.fc13.src.rpm correction, src.rpm... http://dcr226.fedorapeople.org/SRPMS/django-simple-captcha-0.2.0-2.fc13.src.rpm x OK
0 Needs to be fixed
- NA/Not checked
x Package meets naming and packaging guidelines
x Spec file matches base package name.
x Spec has consistant macro usage.
x Meets Packaging Guidelines.
x License
x License field in spec matches
x License file included in package
x Spec in American English
x Spec is legible.
x Sources match upstream md5sum:
638fbc8e135ec7d9be26a5c5cec8b48d django-simple-captcha-0.2.0.tar.gz
- Package needs ExcludeArch
x BuildRequires correct
- Spec handles locales/find_lang
x Package is relocatable and has a reason to be.
x Package has %defattr and permissions on files is good.
x Package has a correct %clean section.
x Package has correct buildroot
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
x Package is code or permissible content.
- Doc subpackage needed/used.
- Packages %doc files don't affect runtime.
- Headers/static libs in -devel subpackage.
- Spec has needed ldconfig in post and postun
- .pc files in -devel subpackage/requires pkgconfig
- .so files in -devel subpackage.
- -devel package Requires: %{name} = %{version}-%{release}
- .la files are removed.
- Package is a GUI app and has a .desktop file
- Package compiles and builds on at least one arch.
x Package has no duplicate files in %files.
x Package doesn't own any directories other packages own.
x Package owns all the directories it creates.
CHECK :
0 No rpmlint output.
rpmlint django-simple-captcha-0.2.0-1.fc13.x86_64.rpm
django-simple-captcha.x86_64: I: enchant-dictionary-not-found en_US
django-simple-captcha.x86_64: W: summary-ended-with-dot C Django application to add captcha images to any Django form.
1 packages and 0 specfiles checked; 0 errors, 1 warnings.
x final provides and requires are sane:
django-simple-captcha-0.2.0-1.fc13.x86_64.rpm
django-simple-captcha = 0.2.0-1.fc13
django-simple-captcha(x86-64) = 0.2.0-1.fc13
=
python(abi) = 2.6
SHOULD Items:
x Should build in mock.
- Should build on all supported archs
- Should function as described.
x Should have sane scriptlets.
- Should have subpackages require base package with fully versioned depend.
x Should have dist tag
x Should package latest version
- check for outstanding bugs on package. (For core merge reviews)
Please fix issues marked 0.
Fixed src.rpm : http://dcr226.fedorapeople.org/SRPMS/django-simple-captcha-0.2.0-3.fc13.src.rpm spec changed and bumped accordingly thanks Fixed description, bumped. http://dcr226.fedorapeople.org/SRPMS/django-simple-captcha-0.2.0-4.fc13.src.rpm Everything seems to be fine. Package Approved.! New Package SCM Request ======================= Package Name: django-simple-captcha Short Description: Django application to add captcha images to any Django form Owners: dcr226 Branches: f12 f13 f14 rawhide InitialCC: hiemanshu Git done (by process-git-requests). django-simple-captcha-0.2.0-4.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/django-simple-captcha-0.2.0-4.fc14 django-simple-captcha-0.2.0-4.fc13 has been submitted as an update for Fedora 13. https://admin.fedoraproject.org/updates/django-simple-captcha-0.2.0-4.fc13 django-simple-captcha-0.2.0-4.fc12 has been submitted as an update for Fedora 12. https://admin.fedoraproject.org/updates/django-simple-captcha-0.2.0-4.fc12 django-simple-captcha-0.2.0-4.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report. django-simple-captcha-0.2.0-4.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report. django-simple-captcha-0.2.0-4.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report. Package Change Request ====================== Package Name: django-simple-captcha` New Branches: el5 el6 Owners: dcr226 Adding this package as its a dependency for fpaste-server which is currently being tested on publictest7. Package Change Request ====================== Package Name: django-simple-captcha New Branches: el5 el6 Owners: dcr226 Git done (by process-git-requests). |