Bug 644883 - Review Request: django-simple-captcha - Django application to add captcha images to any Django form.
Summary: Review Request: django-simple-captcha - Django application to add captcha ima...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Hiemanshu Sharma
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2010-10-20 14:30 UTC by David Riches
Modified: 2011-04-11 19:36 UTC (History)
4 users (show)

Fixed In Version: django-simple-captcha-0.2.0-4.fc14
Clone Of:
Environment:
Last Closed: 2010-10-21 14:11:41 UTC
Type: ---
Embargoed:
hiemanshu: fedora-review+
j: fedora-cvs+


Attachments (Terms of Use)

Description David Riches 2010-10-20 14:30:39 UTC
Spec URL: http://dcr226.fedorapeople.org/SPECS/django-simple-captcha.spec
SRPM URL: http://dcr226.fedorapeople.org/SRPMS/django-simple-captcha-0.2.0-1.fc13.src.rpm
Description: Django Simple Captcha is an extremely simple, yet highly customizable 
Django application to add captcha images to any Django form.

Comment 1 David Riches 2010-10-20 15:28:57 UTC
http://koji.fedoraproject.org/koji/taskinfo?taskID=2544899

Koji scratch build link

Comment 2 Hiemanshu Sharma 2010-10-20 15:34:04 UTC
Taking this for review.

Comment 3 David Riches 2010-10-20 16:47:11 UTC
bumped spec, fixed folder permissions

new src.rpm..

http://dcr226.fedorapeople.org/SRPMS/django-simple-captcha-0.2.0-3.fc13.src.rpm

Comment 4 David Riches 2010-10-20 17:02:35 UTC
correction, src.rpm...

http://dcr226.fedorapeople.org/SRPMS/django-simple-captcha-0.2.0-2.fc13.src.rpm

Comment 5 Hiemanshu Sharma 2010-10-20 17:11:30 UTC
x OK
0 Needs to be fixed
- NA/Not checked

x Package meets naming and packaging guidelines
x Spec file matches base package name.
x Spec has consistant macro usage.
x Meets Packaging Guidelines.
x License
x License field in spec matches
x License file included in package
x Spec in American English
x Spec is legible.
x Sources match upstream md5sum:
638fbc8e135ec7d9be26a5c5cec8b48d  django-simple-captcha-0.2.0.tar.gz
- Package needs ExcludeArch
x BuildRequires correct
- Spec handles locales/find_lang
x Package is relocatable and has a reason to be.
x Package has %defattr and permissions on files is good.
x Package has a correct %clean section.
x Package has correct buildroot
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
x Package is code or permissible content.
- Doc subpackage needed/used.
- Packages %doc files don't affect runtime.

- Headers/static libs in -devel subpackage.
- Spec has needed ldconfig in post and postun
- .pc files in -devel subpackage/requires pkgconfig
- .so files in -devel subpackage.
- -devel package Requires: %{name} = %{version}-%{release}
- .la files are removed.

- Package is a GUI app and has a .desktop file

- Package compiles and builds on at least one arch.
x Package has no duplicate files in %files.
x Package doesn't own any directories other packages own.
x Package owns all the directories it creates.
CHECK :
0 No rpmlint output.
rpmlint django-simple-captcha-0.2.0-1.fc13.x86_64.rpm 
django-simple-captcha.x86_64: I: enchant-dictionary-not-found en_US
django-simple-captcha.x86_64: W: summary-ended-with-dot C Django application to add captcha images to any Django form.
1 packages and 0 specfiles checked; 0 errors, 1 warnings.

x final provides and requires are sane:
django-simple-captcha-0.2.0-1.fc13.x86_64.rpm
django-simple-captcha = 0.2.0-1.fc13
django-simple-captcha(x86-64) = 0.2.0-1.fc13
=
python(abi) = 2.6

SHOULD Items:

x Should build in mock.
- Should build on all supported archs
- Should function as described.
x Should have sane scriptlets.
- Should have subpackages require base package with fully versioned depend.
x Should have dist tag
x Should package latest version
- check for outstanding bugs on package. (For core merge reviews)

Please fix issues marked 0.

Comment 6 David Riches 2010-10-20 17:19:14 UTC
Fixed

src.rpm : http://dcr226.fedorapeople.org/SRPMS/django-simple-captcha-0.2.0-3.fc13.src.rpm

spec changed and bumped accordingly

thanks

Comment 7 David Riches 2010-10-20 19:30:04 UTC
Fixed description, bumped.

http://dcr226.fedorapeople.org/SRPMS/django-simple-captcha-0.2.0-4.fc13.src.rpm

Comment 8 Hiemanshu Sharma 2010-10-20 20:55:25 UTC
Everything seems to be fine.
Package Approved.!

Comment 9 David Riches 2010-10-20 21:06:01 UTC
New Package SCM Request
=======================
Package Name: django-simple-captcha
Short Description: Django application to add captcha images to any Django form
Owners: dcr226
Branches: f12 f13 f14 rawhide
InitialCC: hiemanshu

Comment 10 Kevin Fenzi 2010-10-21 13:32:00 UTC
Git done (by process-git-requests).

Comment 11 Fedora Update System 2010-10-21 14:13:14 UTC
django-simple-captcha-0.2.0-4.fc14 has been submitted as an update for Fedora 14.
https://admin.fedoraproject.org/updates/django-simple-captcha-0.2.0-4.fc14

Comment 12 Fedora Update System 2010-10-21 14:15:07 UTC
django-simple-captcha-0.2.0-4.fc13 has been submitted as an update for Fedora 13.
https://admin.fedoraproject.org/updates/django-simple-captcha-0.2.0-4.fc13

Comment 13 Fedora Update System 2010-10-21 14:16:06 UTC
django-simple-captcha-0.2.0-4.fc12 has been submitted as an update for Fedora 12.
https://admin.fedoraproject.org/updates/django-simple-captcha-0.2.0-4.fc12

Comment 14 Fedora Update System 2010-11-08 22:37:40 UTC
django-simple-captcha-0.2.0-4.fc12 has been pushed to the Fedora 12 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 15 Fedora Update System 2010-11-08 22:42:23 UTC
django-simple-captcha-0.2.0-4.fc13 has been pushed to the Fedora 13 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 16 Fedora Update System 2010-11-08 22:45:25 UTC
django-simple-captcha-0.2.0-4.fc14 has been pushed to the Fedora 14 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 17 Clint Savage 2010-12-19 22:49:39 UTC
Package Change Request
======================
Package Name: django-simple-captcha`
New Branches: el5 el6
Owners: dcr226

Adding this package as its a dependency for fpaste-server which is currently
being tested on publictest7.

Comment 18 David Riches 2011-04-11 19:36:01 UTC
Package Change Request
======================
Package Name: django-simple-captcha
New Branches: el5 el6
Owners: dcr226

Comment 19 Jason Tibbitts 2011-04-11 19:36:29 UTC
Git done (by process-git-requests).


Note You need to log in before you can comment on or make changes to this bug.