Bug 645863
| Summary: | Review Request: python-oauth2 - Python support for improved oauth | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Tom "spot" Callaway <tcallawa> |
| Component: | Package Review | Assignee: | Nobody's working on this, feel free to take it <nobody> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, metherid, notting, sagarun |
| Target Milestone: | --- | Flags: | sagarun:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | python-oauth2-1.2.1-1.fc14 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2010-11-11 22:18:34 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 645233 | ||
|
Description
Tom "spot" Callaway
2010-10-22 17:24:44 UTC
[+] OK
[X] NOT OKAY
[-] NA
[+] Package meets naming and packaging guidelines
[+] Spec file matches base package name.
[+] Spec has consistant macro usage.
[+] Meets Packaging Guidelines.
[+] License
[+] License field in spec matches
[+] License file included in package
[+] Spec in American English
[+] Spec is legible.
[+] Sources match upstream md5sum:
[zer0c00l@gnubox SOURCES]$ md5sum oauth2-1.1.3.tar.gz
79ab3c0af3a6295a699f37d0c25239db oauth2-1.1.3.tar.gz
[-] Package needs ExcludeArch
[+] BuildRequires correct
[-] Spec handles locales/find_lang
[-] Package is relocatable and has a reason to be.
[+] Package has %defattr and permissions on files is good.
[-] Package has a correct %clean section.
[+] Package has correct buildroot
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
[+] Package is code or permissible content.
[-] Doc subpackage needed/used.
[-] Packages %doc files don't affect runtime.
[-] Headers/static libs in -devel subpackage.
[-] Spec has needed ldconfig in post and postun
[-] .pc files in -devel subpackage/requires pkgconfig
[-] .so files in -devel subpackage.
[-] -devel package Requires: %{name} = %{version}-%{release}
[-] .la files are removed.
[-] Package is a GUI app and has a .desktop file
[+] Package compiles and builds on at least one arch.
[+] Package has no duplicate files in %files.
[+] Package doesn't own any directories other packages own.
[+] Package owns all the directories it creates.
[+] No rpmlint output : ignorable
[zer0c00l@gnubox oauth2-1.1.3]$ rpmlint ~/rpmbuild/RPMS/noarch/python-oauth2-1.2.1-1.fc13.noarch.rpm
python-oauth2.noarch: W: spelling-error Summary(en_US) oauth -> oath, auth, o auth
python-oauth2.noarch: W: spelling-error %description -l en_US oauth -> oath, auth, o auth
python-oauth2.noarch: W: spelling-error %description -l en_US py -> pt, p, y
[+] Should build in mock.
[+] Should build on all supported archs
[+] Should function as described.
[-] Should have sane scriptlets.
[-] Should have subpackages require base package with fully versioned depend.
[+] Should have dist tag
[+] Should package latest version
[+] check for outstanding bugs on package. (For core merge reviews)
XXX NOTE XXX
Getting deprecation warning from python-httplib2 when importing oauth2 module
In [1]: import oauth2
/usr/lib/python2.6/site-packages/httplib2/__init__.py:44: DeprecationWarning: the sha module is deprecated; use the hashlib module instead
import sha
Everything seems fine except deprecation warning.
XXXXXXXX Approved XXXXXXXXXX
That deprecation warning is coming from python-httplib2, not python-oauth2. Thanks for the review! New Package SCM Request ======================= Package Name: python-oauth2 Short Description: Python support for improved oauth Owners: spot Branches: f13 f14 InitialCC: Git done (by process-git-requests). python-oauth2-1.2.1-1.fc13 has been submitted as an update for Fedora 13. https://admin.fedoraproject.org/updates/python-oauth2-1.2.1-1.fc13 python-oauth2-1.2.1-1.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/python-oauth2-1.2.1-1.fc14 python-oauth2-1.2.1-1.fc13 has been pushed to the Fedora 13 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update python-oauth2'. You can provide feedback for this update here: https://admin.fedoraproject.org/updates/python-oauth2-1.2.1-1.fc13 python-oauth2-1.2.1-1.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report. python-oauth2-1.2.1-1.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report. Package Change Request ====================== Package Name: python-oauth2 New Branches: el6 Owners: sundaram Package Change Request ====================== Package Name: python-oauth2 New Branches: el6 Owners: sundaram pjp Git done (by process-git-requests). |