Bug 646450

Summary: Replace SETUID in spec file with the correct file capabilities.
Product: [Fedora] Fedora Reporter: Daniel Walsh <dwalsh>
Component: dbusAssignee: David Zeuthen <davidz>
Status: CLOSED WONTFIX QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: low    
Version: rawhideCC: bnocera, davidz, dwalsh, lpoetter, mclasen, mgrepl, walters, walters
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: 646443
: 646452 (view as bug list) Environment:
Last Closed: 2011-04-05 16:39:21 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 693731    

Description Daniel Walsh 2010-10-25 12:58:11 UTC
+++ This bug was initially created as a clone of Bug #646443 +++

Description of problem:

Please remove setuid setup of files in your package with file capabilities.

This is to satisfy the F15 feature.

https://fedoraproject.org/wiki/Features/RemoveSETUID

An example of how this was done for X is.


%if 0%{?fedora} < 15
%define Xorgperms %attr(4711, root, root)
%else
%define Xorgperms %attr(0711,root,root) %caps(cap_sys_admin,cap_sys_rawio,cap_dac_override=pe)
%endif

Comment 1 Daniel Walsh 2011-04-05 13:22:38 UTC
Any movement on this?

Comment 2 Colin Walters 2011-04-05 15:58:10 UTC
We need *all* capabilities in general; the launch helper is used to run arbitrary programs.  It's pretty much an alternative init.  

In practice cap_sys_admin and cap_dac_override would probably be enough, but I don't really want to guess.  How do we request "all"?

Note that in the future hopefully this setuid helper will be going away in favor of asking systemd to do the activation.  See https://bugs.freedesktop.org/show_bug.cgi?id=34526

Comment 3 David Zeuthen 2011-04-05 16:27:06 UTC
Bug 646485 comment 2 is related to this.

Comment 4 Daniel Walsh 2011-04-05 16:39:21 UTC
Thats fine,  Closing WONTFIX, Or could CLOSE NOTABUG.