Bug 647930

Summary: disabling plugin causes agent to send lots of additional availability reports
Product: [Other] RHQ Project Reporter: John Mazzitelli <mazz>
Component: AgentAssignee: John Mazzitelli <mazz>
Status: CLOSED CURRENTRELEASE QA Contact: Corey Welton <cwelton>
Severity: medium Docs Contact:
Priority: low    
Version: 3.0.0   
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
: 648992 651886 (view as bug list) Environment:
Last Closed: 2011-05-24 01:11:21 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 625146, 648992    

Description John Mazzitelli 2010-10-29 21:04:27 UTC
After disabling a plugin, the agent can begin to sends lots of availability reports to the server, more than expected. This happens if you have resources already in inventory (whether committed or not - i.e. in COMMITTED or NEW inventory status).

The problem is in :

org.rhq.core.pc.inventory.InventoryManager.mergeUnknownResources(Set<Integer>)

We weren't removing the IDs from the set being passed in by the caller, thus we never removed the resources that were disabled from the set.

Workaround: re-enable all plugins for which you have resources in inventory OR uninventory all resources that are in inventory that are of types found in plugins that are to be disabled. If the resources are in NEW status, you must commit them first, in order to be able to uninventory them. Its best to do this while the agents are down.

Comment 1 John Mazzitelli 2010-10-29 21:08:19 UTC
this is fixed - master commit: 7155896be74b82b2a9be7b1358103a4e2182fbcf

To test:

1) Start a RHQ Server and RHQ Agent
2) Commit the RHQ Server to inventory
3) Shutdown the agent
3) Go to Administration>Plugins and disable the rhq-server plugin
4) Restart the agent

Watch the server logs for about 10 minutes. After the initial sync between server and agent, you should not see availability reports getting sent up to the server every minute. The default avail scan is 5 minutes so when the agent reaches steady state, it should only send avail reports every 5 minutes. If you see avail reports come into the server every 30s or 60s after the agent has been running 5 or 10 minutes, this bug is still not fixed.

Comment 2 John Mazzitelli 2010-11-10 14:50:14 UTC
cherry-picked over to release-3.0.0 branch: cd5a890ea772fc50d3a0516be63e789070dabf42

Comment 3 Corey Welton 2011-01-04 04:36:42 UTC
QA Verified, after following steps above, I am not seeing reams of avail reports being generated in the server log.

Comment 4 Corey Welton 2011-05-24 01:11:21 UTC
Bookkeeping - closing bug - fixed in recent release.

Comment 5 Corey Welton 2011-05-24 01:11:21 UTC
Bookkeeping - closing bug - fixed in recent release.