Bug 650181
| Summary: | Review Request: tkabber-plugins - Additional plugins for tkabber | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Dmitrij S. Kryzhevich <kryzhev> |
| Component: | Package Review | Assignee: | Peter Lemenkov <lemenkov> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, lemenkov, notting |
| Target Milestone: | --- | Flags: | lemenkov:
fedora-review+
j: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | tkabber-plugins-0.11.1-3.svn1948.fc14 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2011-01-10 21:27:36 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 650180 | ||
| Bug Blocks: | |||
|
Description
Dmitrij S. Kryzhevich
2010-11-05 13:49:41 UTC
taking this for review. Peter, ping? Spec URL: http://krege.fedorapeople.org/tkabber/tkabber-plugins.spec SRPM URL: http://krege.fedorapeople.org/tkabber/tkabber-plugins-0.11.1-2.svn1948.fc14.src.rpm Updated License tag. Ok, the situation with licensing is much better now. Ok, here is my
REVIEW:
Legend: + = PASSED, - = FAILED, 0 = Not Applicable
+ rpmlint is silent
sulaco ~/rpmbuild/SPECS: rpmlint ../RPMS/noarch/tkabber-plugins-0.11.1-2.svn1948.fc12.noarch.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
sulaco ~/rpmbuild/SPECS:
+ The package is named according to the Package Naming Guidelines.
+ The spec file name matches the base package %{name}, in the format %{name}.spec.
+ The package meets the Packaging Guidelines.
+ The package is licensed with a Fedora approved license and meets the Licensing Guidelines.
+ The License field in the package spec file matches the actual license.
+/- All files, containing the text of the license(s) for the package, must be included in %doc. So. please, add also *all* license.terms files. I suggest to rename them in according to particular plugins they corresponds to.
+ The spec file is written in American English.
+ The spec file for the package is legible.
+ The sources used to build the package, match the upstream source, as provided in the spec URL.
sulaco ~/rpmbuild/BUILD: diff -ru tkabber-plugins-0.11.1 tkabber-plugins-0.11.1.from_package/
sulaco ~/rpmbuild/BUILD:
+ The package successfully compiles and builds into binary rpms on at least one primary architecture.
+ All build dependencies are listed in BuildRequires.
0 No need to handle locales.
0 No shared library files.
+ The package does NOT bundle copies of system libraries.
+ The package is not designed to be relocatable.
+ The package owns all directories that it creates.
+ The package does not list a file more than once in the spec file's %files listings.
+ Permissions on files are set properly.
+ The package has a %clean section, which contains rm -rf %{buildroot} (or $RPM_BUILD_ROOT).
+ The package consistently uses macros.
+ The package contains code, or permissible content.
0 No extremely large documentation files.
+ Anything, the package includes as %doc, does not affect the runtime of the application.
0 No header files.
0 No static libraries.
0 No pkgconfig(.pc) files.
0 The package doesn't contain library files with a suffix (e.g. libfoo.so.1.1).
0 No devel sub-package.
+ The package does NOT contain any .la libtool archives.
0 Not a GUI application.
+ The package does not own files or directories already owned by other packages.
+ At the beginning of %install, the package runs rm -rf %{buildroot} (or $RPM_BUILD_ROOT).
+ All filenames in rpm packages are valid UTF-8.
Ok, so, please, add the license files and I'll continue.
As many plugins have same licenses, I think there no need to make copy for each. Also, there are no GPL license files for those plugins that have it. Spec URL: http://krege.fedorapeople.org/tkabber/tkabber-plugins.spec SRPM URL: http://krege.fedorapeople.org/tkabber/tkabber-plugins-0.11.1-3.svn1948.fc14.src.rpm changelog * Wed Dec 15 2010 Dmitrij S. Kryzhevich <krege> - 0.11.1-3.svn1948 - Add license files to %%doc. Ok, now it looks good enough for me. This package is APPROVED. Thanks. New Package SCM Request ======================= Package Name: tkabber-plugins Short Description: Additional plugins for tkabber Owners: krege Branches: f13 f14 InitialCC: Git done (by process-git-requests). tkabber-plugins-0.11.1-3.svn1948.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/tkabber-plugins-0.11.1-3.svn1948.fc14 tkabber-plugins-0.11.1-3.svn1948.fc13 has been submitted as an update for Fedora 13. https://admin.fedoraproject.org/updates/tkabber-plugins-0.11.1-3.svn1948.fc13 tkabber-plugins-0.11.1-3.svn1948.fc13 has been pushed to the Fedora 13 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update tkabber-plugins'. You can provide feedback for this update here: https://admin.fedoraproject.org/updates/tkabber-plugins-0.11.1-3.svn1948.fc13 tkabber-plugins-0.11.1-3.svn1948.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report. tkabber-plugins-0.11.1-3.svn1948.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report. |