Bug 650452
| Summary: | Rename request: meego-cursor-theme - MeeGo X cursors theme | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Peter Robinson <pbrobinson> |
| Component: | Package Review | Assignee: | Adam Williamson <awilliam> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | low | ||
| Version: | rawhide | CC: | awilliam, fedora-package-review, notting |
| Target Milestone: | --- | Flags: | awilliam:
fedora-review+
j: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2010-11-30 16:10:08 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 620175 | ||
|
Description
Peter Robinson
2010-11-06 14:26:56 UTC
rpmlint meego-cursor-theme-0.4-1.20101107git74495cbe.fc15.src.rpm
meego-cursor-theme.src:3: W: macro-in-comment %{name}
meego-cursor-theme.src:3: W: macro-in-comment %{version}
meego-cursor-theme.src:3: W: macro-in-comment %{git_version}
meego-cursor-theme.src:3: W: macro-in-comment %{name}
meego-cursor-theme.src:3: W: macro-in-comment %{version}
meego-cursor-theme.src:3: W: macro-in-comment %{gitdate}
meego-cursor-theme.src: W: no-buildroot-tag
meego-cursor-theme.src: W: invalid-url Source0: meego-cursor-theme-0.4-20101107.tar.bz2
1 packages and 0 specfiles checked; 0 errors, 8 warnings.
rpmlint /var/lib/mock/fedora-rawhide-x86_64/result/meego-cursor-theme-0.4-1.20101107git74495cbe.fc15.noarch.rpm
meego-cursor-theme.noarch: W: incoherent-version-in-changelog 0.4-1 ['0.4-1.20101107git74495cbe.fc15', '0.4-1.20101107git74495cbe']
1 packages and 0 specfiles checked; 0 errors, 1 warnings.
macro-in-comment and invalid-url are OK as they are due to this being a snapshot build and the comment correctly documents the creation of the snapshot. versioning is in line with policy - http://fedoraproject.org/wiki/Packaging:NamingGuidelines#Package_Version . incoherent-version-in-changelog is okay as I understand it, you just chose to leave the snapshot info out of the changelog versioning.
all MUST and SHOULD items are okay and the package builds, review approved.
just one note: the binary RPM contains a bunch of oddly named files: /usr/share/icons/meego/cursors/00008160000006810000408080010102 /usr/share/icons/meego/cursors/028006030e0e7ebffc7f7070c0600140 /usr/share/icons/meego/cursors/03b6e0fcb3499374a867c041f52298f0 /usr/share/icons/meego/cursors/08e8e1c95fe2fc01f976f1e063a24ccd /usr/share/icons/meego/cursors/1081e37283d90000800003c07f3ef6bf /usr/share/icons/meego/cursors/14fef782d02440884392942c11205230 /usr/share/icons/meego/cursors/2870a09082c103050810ffdffffe0204 /usr/share/icons/meego/cursors/3085a0e285430894940527032f8b26df /usr/share/icons/meego/cursors/3ecb610c1bf2410f44200f48c40d3599 /usr/share/icons/meego/cursors/4498f0e0c1937ffe01fd06f973665830 /usr/share/icons/meego/cursors/5c6cd98b3f3ebcb1f9c7f1c204630408 /usr/share/icons/meego/cursors/6407b0e94181790501fd1e167b474872 /usr/share/icons/meego/cursors/640fb0e74195791501fd1ed57b41487f /usr/share/icons/meego/cursors/9081237383d90e509aa00f00170e968f /usr/share/icons/meego/cursors/9d800788f1b08800ae810202380a0822 do these need to be in there? are they some kind of cache? (In reply to comment #2) > just one note: the binary RPM contains a bunch of oddly named files: > > /usr/share/icons/meego/cursors/00008160000006810000408080010102 > > do these need to be in there? are they some kind of cache? They're symbolic links to other files in the same directory. They seem to be a cache or some form of lookup as they're also in other cursor themes. New Package GIT Request ======================= Package Name: meego-cursor-theme Short Description: MeeGo X cursors theme Owners: pbrobinson Branches: F-14 InitialCC: Git done (by process-git-requests). Built in rawhide |