Bug 651227

Please take a look, how to build the python3 subpackage at:
https://fedoraproject.org/wiki/Packaging:Python#Building_more_than_once

That way, building also happens in %build.

I don't think you need the big %if with_python3 macro everywhere, if you only want to build for F13 and up.
Or to which release will this be targeted?

(In reply to comment #1)
> Please take a look, how to build the python3 subpackage at:
> https://fedoraproject.org/wiki/Packaging:Python#Building_more_than_once
> 
> That way, building also happens in %build.
> 
> I don't think you need the big %if with_python3 macro everywhere, if you only
> want to build for F13 and up.
> Or to which release will this be targeted?

I mean with that, please use %py3dir to do the building in another directory, etc

Ok, I'll do that, thank you very much.

And that's targeted for F13 and above only.

Spec URL: http://louizatakk.fedorapeople.org/rpm/python-sleekxmpp.spec
SRPM URL:
http://louizatakk.fedorapeople.org/rpm/python-sleekxmpp-1.0-0.3.beta2.fc13.src.rpm

I fixed that, accordingly with the documentation you pointed.
And I also added the execution of tests in %check

Issues:

- Where do you have the sources from?
  You need to write the commands down, how you generated that tar ball, when using git or somthing (don't find the guideline link atm...)

- Please don't menition python 2.6 or versions like that, it's a XMPP library and that's it :)
  A user doesn't need to know something about the python version, only that it works with the python version currently in fedora ;-)
  Please delete that from summary and description

- Please add acomment, that you didn't add python3-dns yet to Requires

- %files section:
  When you are more explicit with %files, you know when builing an egg failed:
e.g.:
%{python3_sitelib}/sleekxmpp/
%{python3_sitelib}/sleekxmpp-*.egg-info

- INSTALL is not a doc. It helps you to install it, but it's not a documentary for the user later on.

Rest looks ok so far:
- no *.la
- no libs
- name ok


Didn't look for the license yet, will do that, when the issues are gone.

(In reply to comment #5)
> Issues:
> 
> - Where do you have the sources from?
>   You need to write the commands down, how you generated that tar ball, when
> using git or somthing (don't find the guideline link atm...)
> 
It's just a temporary thing. SleekXMPP will be hosted on pypi after the final release. The current problem is that github generates a temporary URL only when browsing the download page. So I hosted it myself, but in the futur it should be OK directly from upstream.
Anyway, fixed in the spec.

> - Please don't menition python 2.6 or versions like that, it's a XMPP library
> and that's it :)
>   A user doesn't need to know something about the python version, only that it
> works with the python version currently in fedora ;-)
>   Please delete that from summary and description
> 
Ok, done

> - Please add acomment, that you didn't add python3-dns yet to Requires
> 
Done

> - %files section:
>   When you are more explicit with %files, you know when builing an egg failed:
> e.g.:
> %{python3_sitelib}/sleekxmpp/
> %{python3_sitelib}/sleekxmpp-*.egg-info
> 
Done

> - INSTALL is not a doc. It helps you to install it, but it's not a documentary
> for the user later on.
>
Done

Spec URL: http://louizatakk.fedorapeople.org/rpm/python-sleekxmpp.spec
SRPM URL:
http://louizatakk.fedorapeople.org/rpm/python-sleekxmpp-1.0-0.4.beta2.fc13.src.rpm

(In reply to comment #6)
> (In reply to comment #5)
> > - Where do you have the sources from?
> >   You need to write the commands down, how you generated that tar ball, when
> > using git or somthing (don't find the guideline link atm...)
> > 
> It's just a temporary thing. SleekXMPP will be hosted on pypi after the final
> release. The current problem is that github generates a temporary URL only when
> browsing the download page. So I hosted it myself, but in the futur it should
> be OK directly from upstream.
> Anyway, fixed in the spec.

There is a regular script running, which checks, if all packages build with the upstream sources. In this case your prackage would pass, because you publish it manually on fedorapeople. Please delete that link, so the package would fail in the sources test.

-> Source0:	sleekxmpp-%{version}-Beta2-0.tar.gz


> > - Please add acomment, that you didn't add python3-dns yet to Requires
> > 
> Done

not done ;)

- License is ok
- R: seem ok

When you fix the source-problem from above, this package is approved.

_________________________________________________


APPROVED

_________________________________________________

(In reply to comment #7)
> There is a regular script running, which checks, if all packages build with the
> upstream sources. In this case your prackage would pass, because you publish it
> manually on fedorapeople. Please delete that link, so the package would fail in
> the sources test.
> 
> -> Source0: sleekxmpp-%{version}-Beta2-0.tar.gz
> 
Ok, done. Now rpmlint complains (two warnings), but I suppose it's the expected behaviour.

> > > - Please add acomment, that you didn't add python3-dns yet to Requires
> > > 
> > Done
> 
> not done ;)
> 
Well, yes, it's done in the   %package -n python3-sleekxmpp   section.

> - License is ok
> - R: seem ok
> 
> When you fix the source-problem from above, this package is approved.
> 
> _________________________________________________
> 
> 
> APPROVED
> 
> _________________________________________________

Thanks
So here is the fixed version:

Spec URL: http://louizatakk.fedorapeople.org/rpm/python-sleekxmpp.spec
SRPM URL:
http://louizatakk.fedorapeople.org/rpm/python-sleekxmpp-1.0-0.5.beta2.fc13.src.rpm

New Package SCM Request
=======================
Package Name: python-sleekxmpp
Short Description: Flexible XMPP client/component/server library for Python
Owners: louizatakk
Branches: f13 f14
InitialCC: louizatakk

(In reply to comment #8)
> > > > - Please add acomment, that you didn't add python3-dns yet to Requires
> > > > 
> > > Done
> > 
> > not done ;)
> > 
> Well, yes, it's done in the   %package -n python3-sleekxmpp   section.

Right, sorry.

Thanks

Git done (by process-git-requests).

Any update on a Fedora build?

python-sleekxmpp-1.0-0.7.beta2.fc14 has been submitted as an update for Fedora 14.
https://admin.fedoraproject.org/updates/python-sleekxmpp-1.0-0.7.beta2.fc14

python-sleekxmpp-1.0-0.7.beta2.fc13 has been submitted as an update for Fedora 13.
https://admin.fedoraproject.org/updates/python-sleekxmpp-1.0-0.7.beta2.fc13

python-sleekxmpp-1.0-0.7.beta2.fc13 has been pushed to the Fedora 13 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update python-sleekxmpp'.  You can provide feedback for this update here: https://admin.fedoraproject.org/updates/python-sleekxmpp-1.0-0.7.beta2.fc13

python-sleekxmpp-1.0-0.7.beta2.fc14 has been pushed to the Fedora 14 stable repository.  If problems still persist, please make note of it in this bug report.

python-sleekxmpp-1.0-0.7.beta2.fc13 has been pushed to the Fedora 13 stable repository.  If problems still persist, please make note of it in this bug report.

Package Change Request
======================
Package Name: python-sleekxmpp
New Branches: el6 epel7
Owners: jamielinux louizatakk