Bug 651693

Summary: Review Request: libxkbcommon - X.Org X11 XKB parsing library
Product: [Fedora] Fedora Reporter: Peter Hutterer <peter.hutterer>
Component: Package ReviewAssignee: Parag AN(पराग) <panemade>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: airlied, fedora-package-review, notting, panemade
Target Milestone: ---Flags: panemade: fedora-review+
gwync: fedora-cvs+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2010-11-11 20:04:22 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1224591    
Attachments:
Description Flags
spec cleanup none

Description Peter Hutterer 2010-11-10 05:51:46 UTC 
Spec URL: http://people.freedesktop.org/~whot/libxkbcommon.spec
SRPM URL: http://people.freedesktop.org/~whot/libxkbcommon-0.1.0-1.20101110.fc14.src.rpm
Description:
libxkbcommon is the X.Org library for compiling XKB maps into formats usable by
the X Server or other display servers.
Comment 1 Parag AN(पराग) 2010-11-10 09:58:38 UTC 
Package failed to build in mock, looks missing BR:byacc and libX11-devel

Following are not blockers but good to implement as packaging guidelines suggests their usage.

1) Guidelines says there is no need of buildroot tag in spec,
https://fedoraproject.org/wiki/PackagingGuidelines#BuildRoot_tag
and also for EPEL, See
https://fedoraproject.org/wiki/EPEL/GuidelinesAndPolicies#BuildRoot_tag

2) See,https://fedoraproject.org/wiki/Packaging/Guidelines#Explicit_Requires
We don't need Requires for -devel as they are automatically extracted by rpm.

3) Guidelines suggests to keep timestamps of upstream installed files. So
please use 
make install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p"

See https://fedoraproject.org/wiki/Packaging/Guidelines#Timestamps

4) Guidelines suggests package built above F-13 do not need %clean
See https://fedoraproject.org/wiki/Packaging/Guidelines#.25clean


5) --disable-specs is a unrecognized option to %configure
Comment 2 Parag AN(पराग) 2010-11-10 10:14:19 UTC 
Created attachment 459390 [details]
spec cleanup

here is successful koji scratch build that used this cleanup patch
http://koji.fedoraproject.org/koji/taskinfo?taskID=2592511
Comment 3 Peter Hutterer 2010-11-10 23:07:02 UTC 
whoops, that's a bit of a brown paper bag moment. thank you, I've applied the diff and uploaded the new spec file and new srpm to the same URLs.

Spec URL: http://people.freedesktop.org/~whot/libxkbcommon.spec
SRPM URL: http://people.freedesktop.org/~whot/libxkbcommon-0.1.0-1.20101110.fc14.src.rpm
Comment 4 Parag AN(पराग) 2010-11-11 04:07:58 UTC 
Looks good now.

APPROVED.
Comment 5 Peter Hutterer 2010-11-11 04:21:41 UTC 
New Package SCM Request
=======================
Package Name: libxkbcommon
Short Description: X.Org X11 XKB parsing library
Owners: whot
Branches:
InitialCC: xgl-maint
Comment 6 Jason Tibbitts 2010-11-11 15:56:22 UTC 
Git done (by process-git-requests).
Comment 7 Adam Jackson 2010-11-11 20:04:22 UTC 
Imported and built in rawhide, closing.
Comment 8 Peter Hutterer 2015-06-02 03:58:07 UTC 
Package Change Request
======================
Package Name: libxkbcommon
New Branches: epel7
Owners:
Comment 9 Gwyn Ciesla 2015-06-02 13:01:48 UTC 
No owner specified.
Comment 10 Peter Hutterer 2015-06-02 23:56:38 UTC 
sorry, I thought it'd use the same owner as the package. Trying again:


Package Change Request
======================
Package Name: libxkbcommon
New Branches: epel7
Owners: whot
Comment 11 Gwyn Ciesla 2015-06-03 04:24:28 UTC 
Git done (by process-git-requests).