Fedora Account System
Red Hat Associate
Red Hat Customer
Spec URL: http://people.freedesktop.org/~whot/libxkbcommon.spec SRPM URL: http://people.freedesktop.org/~whot/libxkbcommon-0.1.0-1.20101110.fc14.src.rpm Description: libxkbcommon is the X.Org library for compiling XKB maps into formats usable by the X Server or other display servers.
Package failed to build in mock, looks missing BR:byacc and libX11-devel Following are not blockers but good to implement as packaging guidelines suggests their usage. 1) Guidelines says there is no need of buildroot tag in spec, https://fedoraproject.org/wiki/PackagingGuidelines#BuildRoot_tag and also for EPEL, See https://fedoraproject.org/wiki/EPEL/GuidelinesAndPolicies#BuildRoot_tag 2) See,https://fedoraproject.org/wiki/Packaging/Guidelines#Explicit_Requires We don't need Requires for -devel as they are automatically extracted by rpm. 3) Guidelines suggests to keep timestamps of upstream installed files. So please use make install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p" See https://fedoraproject.org/wiki/Packaging/Guidelines#Timestamps 4) Guidelines suggests package built above F-13 do not need %clean See https://fedoraproject.org/wiki/Packaging/Guidelines#.25clean 5) --disable-specs is a unrecognized option to %configure
Created attachment 459390 [details] spec cleanup here is successful koji scratch build that used this cleanup patch http://koji.fedoraproject.org/koji/taskinfo?taskID=2592511
whoops, that's a bit of a brown paper bag moment. thank you, I've applied the diff and uploaded the new spec file and new srpm to the same URLs. Spec URL: http://people.freedesktop.org/~whot/libxkbcommon.spec SRPM URL: http://people.freedesktop.org/~whot/libxkbcommon-0.1.0-1.20101110.fc14.src.rpm
Looks good now. APPROVED.
New Package SCM Request ======================= Package Name: libxkbcommon Short Description: X.Org X11 XKB parsing library Owners: whot Branches: InitialCC: xgl-maint
Git done (by process-git-requests).
Imported and built in rawhide, closing.
Package Change Request ====================== Package Name: libxkbcommon New Branches: epel7 Owners:
No owner specified.
sorry, I thought it'd use the same owner as the package. Trying again: Package Change Request ====================== Package Name: libxkbcommon New Branches: epel7 Owners: whot