Bug 651863
Summary: | Review Request: libgnome-media-profiles - GNOME Media Profiles library | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Yanko Kaneti <yaneti> |
Component: | Package Review | Assignee: | Matthias Clasen <mclasen> |
Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | bnocera, fedora-package-review, mclasen, notting |
Target Milestone: | --- | Flags: | mclasen:
fedora-review+
kevin: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2010-11-12 16:56:37 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Yanko Kaneti
2010-11-10 13:56:42 UTC
2.91.2-2 - Add some BRs so that it actually builds in mock. Spec URL: http://declera.com/~yaneti/libgnome-media-profiles/libgnome-media-profiles.spec SRPM URL: http://declera.com/~yaneti/libgnome-media-profiles/libgnome-media-profiles-2.91.2-2.fc15.src.rpm Description: Builds fine in mock. rpmlint output: [mclasen@planemask Desktop]$ rpmlint /var/lib/mock/fedora-rawhide-x86_64/result/libgnome-media-profiles-*.rpm libgnome-media-profiles.src: W: no-cleaning-of-buildroot %clean libgnome-media-profiles.src: W: no-buildroot-tag libgnome-media-profiles.src: W: no-%clean-section libgnome-media-profiles.x86_64: W: non-conffile-in-etc /etc/gconf/schemas/gnome-media-profiles.schemas libgnome-media-profiles.x86_64: W: no-manual-page-for-binary gnome-audio-profiles-properties libgnome-media-profiles.x86_64: W: dangerous-command-in-%post rm libgnome-media-profiles.x86_64: W: dangerous-command-in-%postun rm libgnome-media-profiles-devel.x86_64: E: description-line-too-long C The libgnome-media-profiles-devel package contains libraries and header files for libgnome-media-profiles-devel.x86_64: W: no-documentation 4 packages and 0 specfiles checked; 1 errors, 8 warnings. could perhaps fix the cosmetic line-length error, the rest is expected / rpmlint insufficiency. Comments from Bastien: <hadess> yaneti: in your libgnome-media-profiles package, could you add a sub-package with the glade integration? <hadess> yaneti: and add a provides/obsolete for gnome-media-devel in the devel sub-package package name: ok spec file name: ok packaging guidelines: ok license: ok license field: ok license file: ok spec language: ok spec readable: ok upstream sources: ok buildable: ok excludearch: ok buildrequires: ok locale handling: ok ldconfig: ok system libraries: ok relocatable: ok directory ownership: ok duplicate files: ok file permissions: ok macro use: ok permissible content: ok large docs: ok %doc content: ok header files: ok static libs: ok shared libs: ok devel deps: ok libtool archives: ok file ownership: ok utf8 filenames: ok Summary: shorten the description line, and address hadess' comments, then its good to go. 2.91.2-3 - Shorten the devel description. Spec URL: http://declera.com/~yaneti/libgnome-media-profiles/libgnome-media-profiles.spec SRPM URL: http://declera.com/~yaneti/libgnome-media-profiles/libgnome-media-profiles-2.91.2-3.fc15.src.rpm WRT the glade issue: 2010.11.11 17:53 < yaneti> hadess: mmm I am looking at libgnome-media-profiles git and evertyhing glade there seems to be hypotetical, the am confditional is not used the glade dir is not used... dunno... 2010.11.11 17:54 < hadess> yaneti: let me check 2010.11.11 17:55 < yaneti> hadess: the onyl thing glade3 that i can find is glade3-libgladeui-devel which provides gladeui-1.0 2010.11.11 17:56 < hadess> yaneti: right, you found a bug 2010.11.11 17:56 < hadess> yaneti: i'll fix it in git, and you can ignore that particular TODO item for now 2010.11.11 17:57 < yaneti> hadess: if you fix it in git I can include the patch in the review 2010.11.11 17:57 < hadess> yaneti: nah, it's fine for now I am a doofus, forgot the obsoletes. 2.91.2-4 - Add gnome-media-devel obsoletes to devel Spec URL: http://declera.com/~yaneti/libgnome-media-profiles/libgnome-media-profiles.spec SRPM URL: http://declera.com/~yaneti/libgnome-media-profiles/libgnome-media-profiles-2.91.2-4.fc15.src.rpm duh, and the provides :/ -5 in the same place. Looks good now. Approved New Package SCM Request ======================= Package Name: libgnome-media-profiles Short Description: GNOME Media Profiles library Owners: yaneti hadess Branches: InitialCC: Git done (by process-git-requests). Imported. Built. Thanks everyone and sorry for the noise. |