Bug 651863 - Review Request: libgnome-media-profiles - GNOME Media Profiles library
Summary: Review Request: libgnome-media-profiles - GNOME Media Profiles library
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Matthias Clasen
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2010-11-10 13:56 UTC by Yanko Kaneti
Modified: 2010-11-12 16:56 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2010-11-12 16:56:37 UTC
Type: ---
Embargoed:
mclasen: fedora-review+
kevin: fedora-cvs+


Attachments (Terms of Use)

Description Yanko Kaneti 2010-11-10 13:56:42 UTC
Spec URL: http://declera.com/~yaneti/libgnome-media-profiles/libgnome-media-profiles.spec
SRPM URL: http://declera.com/~yaneti/libgnome-media-profiles/libgnome-media-profiles-2.91.2-1.fc15.src.rpm
Description:
The GNOME Media Profiles library provides prebuilt GStreamer pipelines
for applications aiming to support different sound formats.

libgnome-media-profiles.src: W: no-cleaning-of-buildroot %clean
libgnome-media-profiles.src: W: no-buildroot-tag
libgnome-media-profiles.src: W: no-%clean-section
libgnome-media-profiles.x86_64: W: non-conffile-in-etc /etc/gconf/schemas/gnome-media-profiles.schemas
libgnome-media-profiles.x86_64: W: no-manual-page-for-binary gnome-audio-profiles-properties
libgnome-media-profiles.x86_64: W: dangerous-command-in-%post rm
libgnome-media-profiles.x86_64: W: dangerous-command-in-%postun rm
libgnome-media-profiles-devel.x86_64: E: description-line-too-long C The libgnome-media-profiles-devel package contains libraries and header files for
libgnome-media-profiles-devel.x86_64: W: no-documentation
4 packages and 0 specfiles checked; 1 errors, 8 warnings.

Comment 1 Yanko Kaneti 2010-11-10 16:20:39 UTC
2.91.2-2
- Add some BRs so that it actually builds in mock.
Spec URL:
http://declera.com/~yaneti/libgnome-media-profiles/libgnome-media-profiles.spec
SRPM URL:
http://declera.com/~yaneti/libgnome-media-profiles/libgnome-media-profiles-2.91.2-2.fc15.src.rpm
Description:

Comment 2 Matthias Clasen 2010-11-11 15:20:46 UTC
Builds fine in mock.
rpmlint output:

[mclasen@planemask Desktop]$ rpmlint /var/lib/mock/fedora-rawhide-x86_64/result/libgnome-media-profiles-*.rpm
libgnome-media-profiles.src: W: no-cleaning-of-buildroot %clean
libgnome-media-profiles.src: W: no-buildroot-tag
libgnome-media-profiles.src: W: no-%clean-section
libgnome-media-profiles.x86_64: W: non-conffile-in-etc /etc/gconf/schemas/gnome-media-profiles.schemas
libgnome-media-profiles.x86_64: W: no-manual-page-for-binary gnome-audio-profiles-properties
libgnome-media-profiles.x86_64: W: dangerous-command-in-%post rm
libgnome-media-profiles.x86_64: W: dangerous-command-in-%postun rm
libgnome-media-profiles-devel.x86_64: E: description-line-too-long C The libgnome-media-profiles-devel package contains libraries and header files for
libgnome-media-profiles-devel.x86_64: W: no-documentation
4 packages and 0 specfiles checked; 1 errors, 8 warnings.


could perhaps fix the cosmetic line-length error, the rest is expected / rpmlint insufficiency.

Comment 3 Matthias Clasen 2010-11-11 15:30:30 UTC
Comments from Bastien:

<hadess> yaneti: in your libgnome-media-profiles package, could you add a sub-package with the glade integration?
<hadess> yaneti: and add a provides/obsolete for gnome-media-devel in the devel sub-package

Comment 4 Matthias Clasen 2010-11-11 15:42:11 UTC
package name: ok
spec file name: ok
packaging guidelines: ok
license: ok
license field: ok
license file: ok
spec language: ok
spec readable: ok
upstream sources: ok
buildable: ok
excludearch: ok
buildrequires: ok
locale handling: ok
ldconfig: ok
system libraries: ok
relocatable: ok
directory ownership: ok
duplicate files: ok
file permissions: ok
macro use: ok
permissible content: ok
large docs: ok
%doc content: ok
header files: ok
static libs: ok
shared libs: ok
devel deps: ok
libtool archives: ok
file ownership: ok
utf8 filenames: ok

Summary: shorten the description line, and address hadess' comments, then its good to go.

Comment 5 Yanko Kaneti 2010-11-11 16:05:42 UTC
2.91.2-3
- Shorten the devel description.

Spec URL:
http://declera.com/~yaneti/libgnome-media-profiles/libgnome-media-profiles.spec
SRPM URL:
http://declera.com/~yaneti/libgnome-media-profiles/libgnome-media-profiles-2.91.2-3.fc15.src.rpm


WRT the glade issue:
2010.11.11 17:53 < yaneti> hadess: mmm I am looking at libgnome-media-profiles git and evertyhing glade there seems to be hypotetical, the  am confditional is not used the glade dir is not used...  dunno...
2010.11.11 17:54 < hadess> yaneti: let me check
2010.11.11 17:55 < yaneti> hadess: the onyl thing glade3 that i can find is glade3-libgladeui-devel which provides gladeui-1.0
2010.11.11 17:56 < hadess> yaneti: right, you found a bug
2010.11.11 17:56 < hadess> yaneti: i'll fix it in git, and you can ignore that particular TODO item for now
2010.11.11 17:57 < yaneti> hadess: if you fix it in git I can include the patch in the review
2010.11.11 17:57 < hadess> yaneti: nah, it's fine for now

Comment 6 Yanko Kaneti 2010-11-11 16:20:15 UTC
I am a doofus, forgot the obsoletes.

2.91.2-4
- Add gnome-media-devel obsoletes to devel
Spec URL:
http://declera.com/~yaneti/libgnome-media-profiles/libgnome-media-profiles.spec
SRPM URL:
http://declera.com/~yaneti/libgnome-media-profiles/libgnome-media-profiles-2.91.2-4.fc15.src.rpm

Comment 7 Yanko Kaneti 2010-11-11 16:27:11 UTC
duh, and the provides :/
-5 in the same place.

Comment 8 Matthias Clasen 2010-11-11 17:54:30 UTC
Looks good now. Approved

Comment 9 Yanko Kaneti 2010-11-11 18:03:46 UTC
New Package SCM Request
=======================
Package Name: libgnome-media-profiles
Short Description: GNOME Media Profiles library
Owners: yaneti hadess
Branches:
InitialCC:

Comment 10 Kevin Fenzi 2010-11-12 15:42:21 UTC
Git done (by process-git-requests).

Comment 11 Yanko Kaneti 2010-11-12 16:56:37 UTC
Imported. Built.
Thanks everyone and sorry for the noise.


Note You need to log in before you can comment on or make changes to this bug.