Bug 651886

+++ This bug was initially created as a clone of Bug #647930 +++

After disabling a plugin, the agent can begin to sends lots of availability reports to the server, more than expected. This happens if you have resources already in inventory (whether committed or not - i.e. in COMMITTED or NEW inventory status).

The problem is in :

org.rhq.core.pc.inventory.InventoryManager.mergeUnknownResources(Set<Integer>)

We weren't removing the IDs from the set being passed in by the caller, thus we never removed the resources that were disabled from the set.

Workaround: re-enable all plugins for which you have resources in inventory OR uninventory all resources that are in inventory that are of types found in plugins that are to be disabled. If the resources are in NEW status, you must commit them first, in order to be able to uninventory them. Its best to do this while the agents are down.

--- Additional comment from mazz on 2010-10-29 17:08:19 EDT ---

this is fixed - master commit: 7155896be74b82b2a9be7b1358103a4e2182fbcf

To test:

1) Start a RHQ Server and RHQ Agent
2) Commit the RHQ Server to inventory
3) Shutdown the agent
3) Go to Administration>Plugins and disable the rhq-server plugin
4) Restart the agent

Watch the server logs for about 10 minutes. After the initial sync between server and agent, you should not see availability reports getting sent up to the server every minute. The default avail scan is 5 minutes so when the agent reaches steady state, it should only send avail reports every 5 minutes. If you see avail reports come into the server every 30s or 60s after the agent has been running 5 or 10 minutes, this bug is still not fixed.

--- Additional comment from mazz on 2010-11-10 09:50:14 EST ---

cherry-picked over to release-3.0.0 branch: cd5a890ea772fc50d3a0516be63e789070dabf42