Bug 652522
| Summary: | Bash style cleanup for livecd-iso-to-disk | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Frederick Grose <fgrose> | ||||||||||||||
| Component: | livecd-tools | Assignee: | Brian Lane <bcl> | ||||||||||||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||||||||||
| Severity: | medium | Docs Contact: | |||||||||||||||
| Priority: | low | ||||||||||||||||
| Version: | rawhide | CC: | adam.stokes, bcl, bruno, dhuff, Jasper.Hartline, katzj, wtogami | ||||||||||||||
| Target Milestone: | --- | Keywords: | Reopened | ||||||||||||||
| Target Release: | --- | ||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||
| OS: | Unspecified | ||||||||||||||||
| Whiteboard: | |||||||||||||||||
| Fixed In Version: | livecd-tools-14.0-1.fc14 | Doc Type: | Bug Fix | ||||||||||||||
| Doc Text: | Story Points: | --- | |||||||||||||||
| Clone Of: | Environment: | ||||||||||||||||
| Last Closed: | 2010-12-02 19:13:24 UTC | Type: | --- | ||||||||||||||
| Regression: | --- | Mount Type: | --- | ||||||||||||||
| Documentation: | --- | CRM: | |||||||||||||||
| Verified Versions: | Category: | --- | |||||||||||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||||||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||||||||||
| Embargoed: | |||||||||||||||||
| Attachments: |
|
||||||||||||||||
Created attachment 459933 [details]
Patch to remove tab indentations
Thanks! I was planning on doing that. Created attachment 460144 [details]
Set indentations to 4 spaces.
(More style patches to follow.)
thanks, I'll keep this open until you're done. make sure to rebase on master first. Created attachment 460280 [details]
fix first brace position on isdevloop()
Created attachment 460282 [details]
use $() for command substitution
Latest 3 patches based on master index f59ae91. livecd-tools-14.0-1.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/livecd-tools-14.0-1.fc14 Created attachment 460732 [details]
Indent then blocks
Indent then blocks, and miscellaneous white space fixes around then.
livecd-tools-14.0-1.fc14 has been pushed to the Fedora 14 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update livecd-tools'. You can provide feedback for this update here: https://admin.fedoraproject.org/updates/livecd-tools-14.0-1.fc14 livecd-tools-14.0-1.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report. |
Created attachment 459921 [details] Patch to remove end-of-line spaces Patches to update and standardize the code style.