Bug 652522 - Bash style cleanup for livecd-iso-to-disk
Summary: Bash style cleanup for livecd-iso-to-disk
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: livecd-tools
Version: rawhide
Hardware: Unspecified
OS: Unspecified
low
medium
Target Milestone: ---
Assignee: Brian Lane
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2010-11-12 05:59 UTC by Frederick Grose
Modified: 2010-12-02 19:13 UTC (History)
7 users (show)

Fixed In Version: livecd-tools-14.0-1.fc14
Clone Of:
Environment:
Last Closed: 2010-12-02 19:13:24 UTC
Type: ---
Embargoed:

Attachments (Terms of Use)
Patch to remove end-of-line spaces (2.69 KB, patch)
2010-11-12 05:59 UTC, Frederick Grose 		no flags Details | Diff
Patch to remove tab indentations (14.75 KB, patch)
2010-11-12 06:32 UTC, Frederick Grose 		no flags Details | Diff
Set indentations to 4 spaces. (20.83 KB, patch)
2010-11-12 19:54 UTC, Frederick Grose 		no flags Details | Diff
fix first brace position on isdevloop() (290 bytes, patch)
2010-11-14 00:56 UTC, Frederick Grose 		no flags Details | Diff
use $() for command substitution (370 bytes, patch)
2010-11-14 00:58 UTC, Frederick Grose 		no flags Details | Diff
Indent then blocks (4.09 KB, patch)
2010-11-16 05:14 UTC, Frederick Grose 		no flags Details | Diff
View All

Description Frederick Grose 2010-11-12 05:59:02 UTC 
Created attachment 459921 [details]
Patch to remove end-of-line spaces

Patches to update and standardize the code style.
Comment 1 Frederick Grose 2010-11-12 06:32:07 UTC 
Created attachment 459933 [details]
Patch to remove tab indentations
Comment 2 Brian Lane 2010-11-12 18:01:44 UTC 
Thanks! I was planning on doing that.
Comment 3 Frederick Grose 2010-11-12 19:54:48 UTC 
Created attachment 460144 [details]
Set indentations to 4 spaces.

(More style patches to follow.)
Comment 4 Brian Lane 2010-11-12 21:09:53 UTC 
thanks, I'll keep this open until you're done. make sure to rebase on master first.
Comment 5 Frederick Grose 2010-11-14 00:56:49 UTC 
Created attachment 460280 [details]
fix first brace position on isdevloop()
Comment 6 Frederick Grose 2010-11-14 00:58:05 UTC 
Created attachment 460282 [details]
use $() for command substitution
Comment 7 Frederick Grose 2010-11-14 01:01:27 UTC 
Latest 3 patches based on master index f59ae91.
Comment 8 Fedora Update System 2010-11-16 01:00:50 UTC 
livecd-tools-14.0-1.fc14 has been submitted as an update for Fedora 14.
https://admin.fedoraproject.org/updates/livecd-tools-14.0-1.fc14
Comment 9 Frederick Grose 2010-11-16 05:14:17 UTC 
Created attachment 460732 [details]
Indent then blocks

Indent then blocks, and miscellaneous white space fixes around then.
Comment 10 Fedora Update System 2010-11-16 23:12:14 UTC 
livecd-tools-14.0-1.fc14 has been pushed to the Fedora 14 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update livecd-tools'.  You can provide feedback for this update here: https://admin.fedoraproject.org/updates/livecd-tools-14.0-1.fc14
Comment 11 Fedora Update System 2010-12-02 19:13:09 UTC 
livecd-tools-14.0-1.fc14 has been pushed to the Fedora 14 stable repository.  If problems still persist, please make note of it in this bug report.
Note You need to log in before you can comment on or make changes to this bug.