Bug 656611
| Summary: | Provide /etc/tmpfiles.d/libvirt.conf so systemd+selinux+libvirt plays nice | |||
|---|---|---|---|---|
| Product: | [Community] Virtualization Tools | Reporter: | Lennart Poettering <lpoetter> | |
| Component: | libvirt | Assignee: | Libvirt Maintainers <libvirt-maint> | |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | ||
| Severity: | medium | Docs Contact: | ||
| Priority: | medium | |||
| Version: | unspecified | CC: | berrange, clalance, crobinso, eblake, itamar, jforbes, rbalakri, veillard, virt-maint | |
| Target Milestone: | --- | Keywords: | Reopened | |
| Target Release: | --- | |||
| Hardware: | All | |||
| OS: | Linux | |||
| URL: | http://lists.fedoraproject.org/pipermail/devel-announce/2010-November/000726.html | |||
| Whiteboard: | ||||
| Fixed In Version: | Doc Type: | Bug Fix | ||
| Doc Text: | Story Points: | --- | ||
| Clone Of: | ||||
| : | 758896 758897 (view as bug list) | Environment: | ||
| Last Closed: | 2016-03-22 22:50:28 UTC | Type: | --- | |
| Regression: | --- | Mount Type: | --- | |
| Documentation: | --- | CRM: | ||
| Verified Versions: | Category: | --- | ||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | ||
| Cloudforms Team: | --- | Target Upstream Version: | ||
| Embargoed: | ||||
| Bug Depends On: | ||||
| Bug Blocks: | 758896, 758897, 788985 | |||
|
Description
Lennart Poettering
2010-11-23 23:32:32 UTC
This package has changed ownership in the Fedora Package Database. Reassigning to the new owner of this component. This package has changed ownership in the Fedora Package Database. Reassigning to the new owner of this component. This package has changed ownership in the Fedora Package Database. Reassigning to the new owner of this component. This package has changed ownership in the Fedora Package Database. Reassigning to the new owner of this component. This package has changed ownership in the Fedora Package Database. Reassigning to the new owner of this component. This package has changed ownership in the Fedora Package Database. Reassigning to the new owner of this component. This package has changed ownership in the Fedora Package Database. Reassigning to the new owner of this component. Upstream patch proposed: https://www.redhat.com/archives/libvir-list/2011-November/msg01840.html The next build will have this.
commit 764574f7c73d72e42f69f225b6bbe61fae5ab28b
Author: Eric Blake <eblake>
Date: Wed Nov 30 15:34:42 2011 -0700
spec: mark directories in /var/run as ghosts
We have several directories that are created on the fly, and which
only contain state relevant to a running libvirtd process (all
located in /var/run). Since the directories are created as needed,
and make no sense without a running libvirtd, we want them deleted
if libvirt is uninstalled. And in F15 and newer, /var/run is on
tmpfs (forcing us to recreate on the fly); which means that someone
trying to verify a complete rpm will fail if the directory does not
currently exist because libvirtd has not been started since boot.
The solution, then, is to mark the directories as %ghost, so that
rpm knows that we own them and will clean it up if libvirt is
uninstalled, but will no longer create the directory for us at
install, nor complain at verify time if the directory does not exist.
See https://bugzilla.redhat.com/show_bug.cgi?id=656611.
* libvirt.spec.in (%files): Add %ghost to temporary directories
that we don't install, but want cleaned up on libvirt removal.
Reopening - see bug 788985 - we also need to add /etc/tmpfiles.d/libvirt.conf when targetting systemd, in order for the temporary directory to get created with correct SELinux labels. Since this doesn't seem to have caused much issue in practice, and has lingered for a while, moving to the upstream tracker. I don't think there's actually anything left to do here... AFAIK our current setup hasn't caused any issues |