Bug 657405
Summary: | Review Request: lbzip2 - fast, multi-threaded bzip2 utility | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Lukas Zapletal <lzap> |
Component: | Package Review | Assignee: | Susi Lehtola <susi.lehtola> |
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | drjones, fedora-package-review, lersek, notting, susi.lehtola |
Target Milestone: | --- | Flags: | susi.lehtola:
fedora-review+
petersen: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | lbzip2-0.23-1.fc14 | Doc Type: | Bug Fix |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2010-12-22 00:04:58 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Lukas Zapletal
2010-11-25 19:29:57 UTC
What do Patch0 and Patch1 do? Please make relevant comments in the makefile. Plase be more verbose in %files; there's no need to use wildcards. %{_bindir}/%{name} %{_bindir}/lbzcat %{_bindir}/lbunzip2 %doc %{_mandir}/man1/%{name}.1* %doc %{_mandir}/man1/lbzcat.1* %doc %{_mandir}/man1/lbunzip2.1* rpmlint output as before in comment #0. MUST: The package does not yet exist in Fedora. The Review Request is not a duplicate. OK MUST: The spec file for the package is legible and macros are used consistently. OK MUST: The package must be named according to the Package Naming Guidelines. OK MUST: The spec file name must match the base package %{name}. OK MUST: The package must be licensed with a Fedora approved license and meet the Licensing Guidelines. OK MUST: The License field in the package spec file must match the actual license. OK - No headers in code but README states GPLv2+. MUST: The sources used to build the package must match the upstream source, as provided in the spec URL. OK 72ab7fbfd3804e4ef1a2030f51ac3825 lbzip2-0.23.tar.gz 72ab7fbfd3804e4ef1a2030f51ac3825 ../SOURCES/lbzip2-0.23.tar.gz MUST: The package MUST successfully compile and build into binary rpms. OK MUST: The spec file MUST handle locales properly. N/A MUST: Optflags are used and time stamps preserved. OK MUST: Packages containing shared library files must call ldconfig. N/A MUST: A package must own all directories that it creates or require the package that owns the directory. OK MUST: Files only listed once in %files listings. OK MUST: Debuginfo package is complete. OK MUST: Permissions on files must be set properly. OK MUST: Large documentation files must go in a -doc subpackage. N/A MUST: All relevant items are included in %doc. Items in %doc do not affect runtime of application. OK MUST: Header files must be in a -devel package. N/A MUST: Static libraries must be in a -static package. N/A MUST: If a package contains library files with a suffix then library files ending in .so must go in a -devel package. N/A MUST: In the vast majority of cases, devel packages must require the base package using a fully versioned dependency. N/A MUST: Packages does not contain any .la libtool archives. N/A MUST: Desktop files are installed properly. N/A MUST: No file conflicts with other packages and no general names. OK SHOULD: %{?dist} tag is used in release. OK SHOULD: If the package does not include license text(s) as separate files from upstream, the packager should query upstream to include it. OK SHOULD: The package builds in mock. OK EPEL: Clean section exists. OK EPEL: Buildroot cleaned before install. OK EPEL: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig'. N/A Package APPROVED. Please address issues in comment #1 before git import. New Package SCM Request ======================= Package Name: lbzip2 Short Description: Fast multi-threaded implementation of bzip2 Owners: lzap Branches: f14 InitialCC: @Jussi: Thank you. Will correct it and add comments. Correcting the fedora-cvs flag. Git done (by process-git-requests). lbzip2-0.23-1.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/lbzip2-0.23-1.fc14 lbzip2-0.23-1.fc14 has been pushed to the Fedora 14 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update lbzip2'. You can provide feedback for this update here: https://admin.fedoraproject.org/updates/lbzip2-0.23-1.fc14 lbzip2-0.23-1.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report. New branch request for lbzip2: (http://fedoraproject.org/wiki/PackageMaintainers/CVSAdminProcedure#other) Package Change Request ====================== Package Name: lbzip2 New Branches: el4 el5 el6 Owners: lzap *** Justification: seems like we'd like to use lbzip2 for virt perf testing, and it's more straightforward to install EPEL-x packages for RHEL-x than to fish them out of Fedora. *** Changes likely needed: the current spec file specifies BuildRequires: bzip2-devel >= 1.0.6, dash, sharutils Requires: bzip2-libs >= 1.0.6 The bzip2-devel, bzip2-libs versions require 1.0.6+ only due to a secvuln fixed in upstream 1.0.6: "Version 1.0.6 removes a potential security vulnerability, CVE-2010-0405, so all users are recommended to upgrade immediately." (http://bzip.org/) However, such fixes are always backported to / instantiated for all RHEL versions: https://bugzilla.redhat.com/show_bug.cgi?id=CVE-2010-0405 RHEL-4 ships bzip2-*-1.0.2, RHEL-5 ships bzip2-*-1.0.3, RHEL-6 ships something more recent than that. There's no earlier EPEL than EPEL-4. Therefore I suggest removing the bzip2 dependency version numbers from the spec file, on *all* three EPEL branches. lbzip2 only needs API compatibility, which is ensured by any 1.0.x. *** Why I didn't add myself to the Owners field even now: Because I want to keep my upstream work on lbzip2 strictly isolated from my work paid-for by Red Hat. Lukas, I'll buy you a beer of your preference after working hours :) Thanks! (In reply to comment #10) > However, such fixes are always backported to / instantiated for all RHEL > versions: I don't know what just happened to the previous comment, the bug I meant was bug 627882. Setting CVS flag for the EPEL request. Git done (by process-git-requests). lbzip2-0.23-2.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/lbzip2-0.23-2.el6 lbzip2-0.23-2.el5 has been submitted as an update for Fedora EPEL 5. https://admin.fedoraproject.org/updates/lbzip2-0.23-2.el5 lbzip2-0.23-3.el4 has been submitted as an update for Fedora EPEL 4. https://admin.fedoraproject.org/updates/lbzip2-0.23-3.el4 lbzip2-0.23-3.el5 has been submitted as an update for Fedora EPEL 5. https://admin.fedoraproject.org/updates/lbzip2-0.23-3.el5 lbzip2-0.23-3.el4 has been pushed to the Fedora EPEL 4 stable repository. lbzip2-0.23-2.el6 has been pushed to the Fedora EPEL 6 stable repository. lbzip2-0.23-3.el5 has been pushed to the Fedora EPEL 5 stable repository. lbzip2-2.2-1.el5 has been submitted as an update for Fedora EPEL 5. https://admin.fedoraproject.org/updates/lbzip2-2.2-1.el5 lbzip2-2.2-1.el5 has been pushed to the Fedora EPEL 5 stable repository. If problems still persist, please make note of it in this bug report. |