Bug 659469

Summary:	kickstart.profile.system.getPartitioningScheme - does not return %include statements
Product:	Red Hat Satellite 5	Reporter:	Xixi <xdmoon>
Component:	API	Assignee:	Tomas Lestach <tlestach>
Status:	CLOSED ERRATA	QA Contact:	Dimitar Yordanov <dyordano>
Severity:	medium	Docs Contact:
Priority:	high
Version:	530	CC:	aparsons, cperry, dyordano, fnadge, tscherf, xdmoon
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:	Cause: kickstart.profile.system.getPartitioningScheme API call does not return %include statements Consequence: Part of the params aren't available via API, but visible on WebUI. Fix: Introducing include statements for this API call. Result: Include statements available via API.	Story Points:	---
Clone Of:	584860	Environment:
Last Closed:	2011-02-01 10:32:07 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	584860
Bug Blocks:	518253

Description Xixi 2010-12-02 21:03:15 UTC

Cloning for Satellite 5.3 backport/hotfix request.

+++ This bug was initially created as a clone of Bug #584860 +++

Description of problem:
The kickstart.profile.system.getPartitioningScheme() method filters out %include statements that are in the 'partitions' section of the Kickstart.  Since these lines are valid, they should not be filtered in the output from the API call.

Version-Release number of selected component (if applicable):
Satellite 5.3.0

How reproducible:
Always

Steps to Reproduce:
1. put an %include statement in the 'partitions' section of a Kickstart
2. use the kickstart.profile.system.getPartitioningScheme() method to get the contents of the 'partitions' section
  
Actual results:
%include lines are filtered out

Expected results:
%include lines should be returned since they are valid

--- Additional comment from tlestach on 2010-07-20 05:47:12 EDT ---

getPartitioningScheme returns all partition sections now

spacewalk.git:
 b4a435b051e94a091b7fb77650f28f7909980ec3
 06ec96740de2c57173b40bef416c80eec38962aa

Comment 10 Dimitar Yordanov 2011-01-17 10:02:44 UTC

I face a problem on s390x arch.
When %include is not followed by any string
kickstart.profile.system.getPartitioningScheme() generate traceback.


Partition details:

partition swap --size=1000   --maxsize=2000
partition /boot --fstype=ext3 --size=200
partition pv.01 --size=1000 --grow

volgroup myvg pv.01

logvol / --vgname=myvg --name=rootvol --size=1000 --grow

%include


Result:

Traceback (most recent call last):
  File "/tmp/test", line 7, in ?
    result = sc.kickstart.profile.system.getPartitioningScheme(sk,'test_9751')
  File "/usr/lib64/python2.4/xmlrpclib.py", line 1096, in __call__
    return self.__send(self.__name, args)
  File "/usr/lib64/python2.4/xmlrpclib.py", line 1383, in __request
    verbose=self.__verbose
  File "/usr/lib64/python2.4/xmlrpclib.py", line 1147, in request
    return self._parse_response(h.getfile(), sock)
  File "/usr/lib64/python2.4/xmlrpclib.py", line 1286, in _parse_response
    return u.close()
  File "/usr/lib64/python2.4/xmlrpclib.py", line 744, in close
    raise Fault(**self._stack[0])
xmlrpclib.Fault: <Fault -1: 'redstone.xmlrpc.XmlRpcFault: unhandled internal
exception: null'>


In case there is space before %include all goes well. On x86_64 this space is
generated and the problem does not appeared.

Comment 11 Florian Nadge 2011-01-17 13:56:36 UTC

Please be so kind and add a few key words to the Technical Notes of this
Bugzilla entry using the following structure:

Cause:

Consequence:

Fix:

Result:

For details, see:

https://bugzilla.redhat.com/page.cgi?id=fields.html#cf_release_notes

Thanks

Comment 12 Florian Nadge 2011-01-17 13:56:36 UTC

    Technical note added. If any revisions are required, please edit the "Technical Notes" field
    accordingly. All revisions will be proofread by the Engineering Content Services team.
    
    New Contents:
Cause:

Consequence:

Fix:

Result:

Comment 13 Tomas Lestach 2011-01-17 15:09:16 UTC

Filling up Technical Notes.

Comment 14 Tomas Lestach 2011-01-17 15:09:16 UTC

    Technical note updated. If any revisions are required, please edit the "Technical Notes" field
    accordingly. All revisions will be proofread by the Engineering Content Services team.
    
    Diffed Contents:
@@ -1,7 +1,8 @@
 Cause:
-
+kickstart.profile.system.getPartitioningScheme API call does not return %include statements
 Consequence:
-
+Part of the params aren't available via API, but visible on WebUI.
 Fix:
-
+Introducing include statements for this API call.
-Result:+Result:
+Include statements available via API.

Comment 15 Dimitar Yordanov 2011-01-19 22:16:38 UTC

Verified.
RHEL5 - s390x,x86_64
RHEL4 - x86_64

Comment 16 errata-xmlrpc 2011-02-01 10:32:07 UTC

An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHBA-2011-0189.html