Bug 659950

Summary:	Review Request: vgrabbj - A command-line v4l grabber
Product:	[Fedora] Fedora	Reporter:	Elad Alfassa <elad>
Component:	Package Review	Assignee:	Nobody's working on this, feel free to take it <nobody>
Status:	CLOSED WONTFIX	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	low
Version:	rawhide	CC:	fedora-package-review, mail, notting, panemade, terje.rosten
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2011-03-28 14:03:44 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	659951

Description Elad Alfassa 2010-12-04 12:09:00 UTC

Spec URL: http://elad.fedorapeople.org/reviews/vgrabbj.spec
SRPM URL: http://elad.fedorapeople.org/reviews/vgrabbj-0.9.6-1.fc14.src.rpm
Description: "vgrabbj is a commandline tool that grabs an image from a 24-bit v4l device (like a webcam) and save it as a ppm, png or jpg file"

Comment 1 Terje Røsten 2010-12-04 19:46:44 UTC

Some  missing buildreq here? A koji build gives:

configure: warning: *** libttf library not found! Disabled timestamp feature ***
checking for freetype/freetype.h... no
checking for freetype1/freetype.h... no
checking for crc32 in -lz... configure: warning: *** freetype.h not found! Timestamp may be disabled ***
yes
checking for FtpInit in -lftp... no
configure: warning: *** ftp library not found! Disabled ftp feature ***
checking for ftplib.h... no
checking for crc32 in -lz... configure: warning: *** ftplib.h not found! Disabled ftp feature ***
(cached) yes


Ref: http://koji.fedoraproject.org/koji/getfile?taskID=2643951&name=build.log

Comment 2 Elad Alfassa 2010-12-04 20:22:39 UTC

i didn't enable ftp and timestamp features on purpose

i tested it, and seems that with ftp feature, it won't compile, and i can't enable the timestamp feature because it requires older version of freetype (freetype1) which isn't in fedora.

so it's ok to ignore these warnings.

Comment 3 Fabian Affolter 2011-01-05 08:48:32 UTC

Just some quick comments:

- All doc files (AUTHORS, ChangeLog, etc) should be mentioned in %doc
- Man pages shouldn't have %doc
- One line per BR and requirement makes the file more legible

Comment 4 Elad Alfassa 2011-03-28 14:03:44 UTC

As i've said in bug #636819 comment 19, I'm dropping this review request because of dead upstream.
Feel free to take over this review request if you like.