Spec URL: http://elad.fedorapeople.org/reviews/vgrabbj.spec SRPM URL: http://elad.fedorapeople.org/reviews/vgrabbj-0.9.6-1.fc14.src.rpm Description: "vgrabbj is a commandline tool that grabs an image from a 24-bit v4l device (like a webcam) and save it as a ppm, png or jpg file"
Some missing buildreq here? A koji build gives: configure: warning: *** libttf library not found! Disabled timestamp feature *** checking for freetype/freetype.h... no checking for freetype1/freetype.h... no checking for crc32 in -lz... configure: warning: *** freetype.h not found! Timestamp may be disabled *** yes checking for FtpInit in -lftp... no configure: warning: *** ftp library not found! Disabled ftp feature *** checking for ftplib.h... no checking for crc32 in -lz... configure: warning: *** ftplib.h not found! Disabled ftp feature *** (cached) yes Ref: http://koji.fedoraproject.org/koji/getfile?taskID=2643951&name=build.log
i didn't enable ftp and timestamp features on purpose i tested it, and seems that with ftp feature, it won't compile, and i can't enable the timestamp feature because it requires older version of freetype (freetype1) which isn't in fedora. so it's ok to ignore these warnings.
Just some quick comments: - All doc files (AUTHORS, ChangeLog, etc) should be mentioned in %doc - Man pages shouldn't have %doc - One line per BR and requirement makes the file more legible
As i've said in bug #636819 comment 19, I'm dropping this review request because of dead upstream. Feel free to take over this review request if you like.