Bug 663213
| Summary: | Review Request: perl-File-Inplace - Perl module for in-place editing of files | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Ruediger Landmann <rlandman> |
| Component: | Package Review | Assignee: | Iain Arnell <iarnell> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, iarnell, notting |
| Target Milestone: | --- | Flags: | iarnell:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2010-12-22 01:35:18 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 664359 | ||
|
Description
Ruediger Landmann
2010-12-15 00:25:54 UTC
How did I never spot this module before? + source files match upstream.
fae0848ebef6969502dde017805a31a1 File-Inplace-0.20.tar.gz
+ package meets naming and versioning guidelines.
+ specfile is properly named, is cleanly written and uses macros consistently.
+ summary is OK.
+ description is OK.
+ dist tag is present.
+ license field matches the actual license.
GPL+ or Artistic
+ license is open source-compatible.
+ license text not included upstream.
+ latest version is being packaged.
+ BuildRequires are proper.
+ compiler flags are appropriate.
+ package builds in mock
https://koji.fedoraproject.org/koji/taskinfo?taskID=2664417
+ package installs properly.
+ rpmlint has no useful complaints:
2 packages and 0 specfiles checked; 0 errors, 5 warnings.
[iarnell@microstar perl-File-Inplace]$ rpmlint -v ~/dl/perl-File-Inplace-0.20-1.fc15.*rpm
perl-File-Inplace.noarch: I: checking
perl-File-Inplace.noarch: W: spelling-error %description -l en_US unchomping -> uncomplaining, uncompromising, uncomprehending
perl-File-Inplace.noarch: I: checking-url http://search.cpan.org/dist/File-Inplace/ (timeout 10 seconds)
perl-File-Inplace.src: I: checking
perl-File-Inplace.src: W: spelling-error %description -l en_US unchomping -> uncomplaining, uncompromising, uncomprehending
perl-File-Inplace.src: I: checking-url http://search.cpan.org/dist/File-Inplace/ (timeout 10 seconds)
perl-File-Inplace.src: W: no-cleaning-of-buildroot %clean
perl-File-Inplace.src: W: no-buildroot-tag
perl-File-Inplace.src: W: no-%clean-section
perl-File-Inplace.src: I: checking-url http://www.cpan.org/modules/by-module/File/File-Inplace-0.20.tar.gz (timeout 10 seconds)
2 packages and 0 specfiles checked; 0 errors, 5 warnings.
+ final provides and requires are sane:
perl(File::Inplace) = 0.20
perl-File-Inplace = 0.20-1.fc15
=
perl(Carp)
perl(File::Basename)
perl(File::Copy)
perl(File::Temp)
perl(IO::File)
perl(IO::Handle)
perl(:MODULE_COMPAT_5.12.2)
perl(strict)
rpmlib(CompressedFileNames) <= 3.0.4-1
rpmlib(FileDigests) <= 4.6.0-1
rpmlib(PayloadFilesHavePrefix) <= 4.0-1
rpmlib(PayloadIsXz) <= 5.2-1
rpmlib(VersionedDependencies) <= 3.0.3-1
+ %check is present and all tests pass.
+ make test
PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0, 'blib/lib', 'blib/arch')" t/*.t
t/File-Inplace.t .. ok
All tests successful.
Files=1, Tests=21, 0 wallclock secs ( 0.03 usr 0.01 sys + 0.07 cusr 0.00 csys = 0.11 CPU)
Result: PASS
+ no shared libraries are added to the regular linker search paths.
+ owns the directories it creates.
+ doesn't own any directories it shouldn't.
+ no duplicates in %files.
+ file permissions are appropriate.
+ no generically named files
+ code, not content.
+ documentation is small, so no -doc subpackage is necessary.
+ %docs are not necessary for the proper functioning of the package.
APPROVED.
Thanks for the review, Iain :) New Package SCM Request ======================= Package Name: perl-File-Inplace Short Description: Perl module for in-place editing of files Owners: rlandmann Branches: f13 f14 el6 InitialCC: perl-sig Sorry -- should do EL5 too: New Package SCM Request ======================= Package Name: perl-File-Inplace Short Description: Perl module for in-place editing of files Owners: rlandmann Branches: f13 f14 el5 el6 InitialCC: perl-sig Git done (by process-git-requests). |