Spec URL: http://rlandmann.fedorapeople.org/perl-File-Inplace/perl-File-Inplace.spec SRPM URL: http://rlandmann.fedorapeople.org/perl-File-Inplace/perl-File-Inplace-0.20-1.fc14.src.rpm Description: File::Inplace is a perl module intended to ease the common task of editing a file in-place. Inspired by variations of perl's -i option, this module is intended for somewhat more structured and reusable editing than command line perl typically allows. File::Inplace endeavors to guarantee file integrity; that is, either all of the changes made will be saved to the file, or none will. It also offers functionality such as backup creation, automatic field splitting per-line, automatic chomping/unchomping, and aborting edits partially through without affecting the original file. rpmlint output: $ rpmlint SPECS/perl-File-Inplace.spec SPECS/perl-File-Inplace.spec: W: no-cleaning-of-buildroot %clean SPECS/perl-File-Inplace.spec: W: no-buildroot-tag SPECS/perl-File-Inplace.spec: W: no-%clean-section 0 packages and 1 specfiles checked; 0 errors, 3 warnings. $ rpmlint SRPMS/perl-File-Inplace-0.20-1.fc14.src.rpm perl-File-Inplace.src: W: spelling-error %description -l en_US unchomping -> uncomplaining, uncompromising, uncomprehending perl-File-Inplace.src: W: no-cleaning-of-buildroot %clean perl-File-Inplace.src: W: no-buildroot-tag perl-File-Inplace.src: W: no-%clean-section 1 packages and 0 specfiles checked; 0 errors, 4 warnings. $ rpmlint RPMS/noarch/perl-File-Inplace-0.20-1.fc14.noarch.rpm perl-File-Inplace.noarch: W: spelling-error %description -l en_US unchomping -> uncomplaining, uncompromising, uncomprehending 1 packages and 0 specfiles checked; 0 errors, 1 warnings. Scratchbuilds in Koji: F15 -- https://koji.fedoraproject.org/koji/taskinfo?taskID=2664417 F14 -- https://koji.fedoraproject.org/koji/taskinfo?taskID=2664684
How did I never spot this module before?
+ source files match upstream. fae0848ebef6969502dde017805a31a1 File-Inplace-0.20.tar.gz + package meets naming and versioning guidelines. + specfile is properly named, is cleanly written and uses macros consistently. + summary is OK. + description is OK. + dist tag is present. + license field matches the actual license. GPL+ or Artistic + license is open source-compatible. + license text not included upstream. + latest version is being packaged. + BuildRequires are proper. + compiler flags are appropriate. + package builds in mock https://koji.fedoraproject.org/koji/taskinfo?taskID=2664417 + package installs properly. + rpmlint has no useful complaints: 2 packages and 0 specfiles checked; 0 errors, 5 warnings. [iarnell@microstar perl-File-Inplace]$ rpmlint -v ~/dl/perl-File-Inplace-0.20-1.fc15.*rpm perl-File-Inplace.noarch: I: checking perl-File-Inplace.noarch: W: spelling-error %description -l en_US unchomping -> uncomplaining, uncompromising, uncomprehending perl-File-Inplace.noarch: I: checking-url http://search.cpan.org/dist/File-Inplace/ (timeout 10 seconds) perl-File-Inplace.src: I: checking perl-File-Inplace.src: W: spelling-error %description -l en_US unchomping -> uncomplaining, uncompromising, uncomprehending perl-File-Inplace.src: I: checking-url http://search.cpan.org/dist/File-Inplace/ (timeout 10 seconds) perl-File-Inplace.src: W: no-cleaning-of-buildroot %clean perl-File-Inplace.src: W: no-buildroot-tag perl-File-Inplace.src: W: no-%clean-section perl-File-Inplace.src: I: checking-url http://www.cpan.org/modules/by-module/File/File-Inplace-0.20.tar.gz (timeout 10 seconds) 2 packages and 0 specfiles checked; 0 errors, 5 warnings. + final provides and requires are sane: perl(File::Inplace) = 0.20 perl-File-Inplace = 0.20-1.fc15 = perl(Carp) perl(File::Basename) perl(File::Copy) perl(File::Temp) perl(IO::File) perl(IO::Handle) perl(:MODULE_COMPAT_5.12.2) perl(strict) rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(PayloadIsXz) <= 5.2-1 rpmlib(VersionedDependencies) <= 3.0.3-1 + %check is present and all tests pass. + make test PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0, 'blib/lib', 'blib/arch')" t/*.t t/File-Inplace.t .. ok All tests successful. Files=1, Tests=21, 0 wallclock secs ( 0.03 usr 0.01 sys + 0.07 cusr 0.00 csys = 0.11 CPU) Result: PASS + no shared libraries are added to the regular linker search paths. + owns the directories it creates. + doesn't own any directories it shouldn't. + no duplicates in %files. + file permissions are appropriate. + no generically named files + code, not content. + documentation is small, so no -doc subpackage is necessary. + %docs are not necessary for the proper functioning of the package. APPROVED.
Thanks for the review, Iain :) New Package SCM Request ======================= Package Name: perl-File-Inplace Short Description: Perl module for in-place editing of files Owners: rlandmann Branches: f13 f14 el6 InitialCC: perl-sig
Sorry -- should do EL5 too: New Package SCM Request ======================= Package Name: perl-File-Inplace Short Description: Perl module for in-place editing of files Owners: rlandmann Branches: f13 f14 el5 el6 InitialCC: perl-sig
Git done (by process-git-requests).