Bug 663384
| Summary: | Review Request: scap-workbench - GUI tool that provides scanning, tailoring, editing and validation functionality for SCAP content | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Maros Barabas <mbarabas> |
| Component: | Package Review | Assignee: | Tomas Mraz <tmraz> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, mpreisle, notting, pvrabec, rvokal, tmraz |
| Target Milestone: | --- | Flags: | tmraz:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | scap-workbench-0.2.3-1.fc15 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2011-08-16 09:00:14 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Maros Barabas
2010-12-15 15:48:42 UTC
The debuging to console should be probably turned-off. Please add a desktop entry for the GUI application. According to the guidelines GUI applications should have an appropriate desktop entry. https://fedoraproject.org/wiki/Packaging/Guidelines#Desktop_files Please review package against new version of package. Source file: https://fedorahosted.org/released/scap-workbench/scap-workbench-0.2.0.tar.bz2 SPEC: https://fedorahosted.org/scap-workbench/attachment/wiki/WikiStart/scap-workbench.spec?format=raw You should post a full new src.rpm for download - at least that is what's required by the review rules. I suggest a better formatting of the Name in the desktop file - SCAP Workbench perhaps? But this is by no means a blocker.
I think the license is GPLv3+ as see the ...or any later version... clause in the header comments of the sources.
%{_sysconfdir}/scap-workbench directory is not owned by the package.
You use /usr/share instead of %{_datadir}.
SRPM updated, URL is the same as in comment #5. rpmlint -v scap-workbench-0.2.0-1.fc14.src.rpm scap-workbench-0.2.0-1.fc14.noarch.rpm scap-workbench.src: I: checking scap-workbench.noarch: I: checking 2 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint is silent. I have reviewed the SPEC file and the package. I've also tried to run the utility and it seems that at least the application window appears. I did not test the functionality though. The package now conforms to the Fedora packaging guidelines and is thus APPROVED. New Package SCM Request ======================= Package Name: scap-workbench Short Description: GUI tool that provides scanning, tailoring, editing and validation functionality for SCAP content Owners: mbarabas pvrabec Branches: f14 f15 f15 is not a valid branch - please resubmit with correct branches. New Package SCM Request ======================= Package Name: scap-workbench Short Description: GUI tool that provides scanning, tailoring, editing and validation functionality for SCAP content Owners: mbarabas pvrabec Branches: f14 Git done (by process-git-requests). Package Change Request ====================== Package Name: scap-workbench New Branches: el6 Owners: mpreisle Git done (by process-git-requests). |