Spec URL: https://fedorahosted.org/scap-workbench/attachment/wiki/WikiStart/scap-workbench.spec?format=raw SRPM URL: https://fedorahosted.org/scap-workbench/attachment/wiki/WikiStart/scap-workbench-0.1.0-1.fc13.src.rpm?format=raw Description: Scap Workbench is a GUI tool that provides scanning, tailoring, editing and validation functionality for SCAP content. It uses openscap library to access SCAP functionalities.
The debuging to console should be probably turned-off.
Please add a desktop entry for the GUI application. According to the guidelines GUI applications should have an appropriate desktop entry. https://fedoraproject.org/wiki/Packaging/Guidelines#Desktop_files
Please review package against new version of package. Source file: https://fedorahosted.org/released/scap-workbench/scap-workbench-0.2.0.tar.bz2 SPEC: https://fedorahosted.org/scap-workbench/attachment/wiki/WikiStart/scap-workbench.spec?format=raw
You should post a full new src.rpm for download - at least that is what's required by the review rules.
SRPM URL: https://fedorahosted.org/scap-workbench/attachment/wiki/WikiStart/scap-workbench-0.2.0-1.fc13.src.rpm?format=raw
I suggest a better formatting of the Name in the desktop file - SCAP Workbench perhaps? But this is by no means a blocker. I think the license is GPLv3+ as see the ...or any later version... clause in the header comments of the sources. %{_sysconfdir}/scap-workbench directory is not owned by the package. You use /usr/share instead of %{_datadir}.
SRPM updated, URL is the same as in comment #5.
rpmlint -v scap-workbench-0.2.0-1.fc14.src.rpm scap-workbench-0.2.0-1.fc14.noarch.rpm scap-workbench.src: I: checking scap-workbench.noarch: I: checking 2 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint is silent. I have reviewed the SPEC file and the package. I've also tried to run the utility and it seems that at least the application window appears. I did not test the functionality though. The package now conforms to the Fedora packaging guidelines and is thus APPROVED.
New Package SCM Request ======================= Package Name: scap-workbench Short Description: GUI tool that provides scanning, tailoring, editing and validation functionality for SCAP content Owners: mbarabas pvrabec Branches: f14 f15
f15 is not a valid branch - please resubmit with correct branches.
New Package SCM Request ======================= Package Name: scap-workbench Short Description: GUI tool that provides scanning, tailoring, editing and validation functionality for SCAP content Owners: mbarabas pvrabec Branches: f14
Git done (by process-git-requests).
Package Change Request ====================== Package Name: scap-workbench New Branches: el6 Owners: mpreisle